linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: avidanborisov@gmail.com
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] trace-cmd record: Improvements to --daemonize option
Date: Sat, 1 Jul 2023 21:39:15 -0400	[thread overview]
Message-ID: <20230701213915.482b5ff6@rorschach.local.home> (raw)
In-Reply-To: <20230626091635.3002827-1-avidanborisov@gmail.com>

On Mon, 26 Jun 2023 12:16:31 +0300
avidanborisov@gmail.com wrote:

> From: Avidan Borisov <avidanborisov@gmail.com>
> 
> Hi Steven,

Thanks Avidan,

I'm currently traveling and then we have two US holidays for Monday and
Tuesday, I'll try to get to it within a week or two.

Also, when sending a v2, please make it a new thread and do not reply
to the previous version. It makes it more visible, otherwise, the
second version gets lost in the thread of the first.

Thanks,

-- Steve


> 
> This is the second version of my patch series for adding the --daemonize option to trace-cmd record, incorporating your feedback.
> 
> Changes since v1:
> - Replaced all instances of "he" with "the user".
> - Fixed the issue with the `break` statement in the switch case.
> - Added a usage example of --daemonize to the man page.
> 
> Let me know if there are any further changes required.
> 
> Thanks,
> Avidan
> 
> Avidan Borisov (4):
>   trace-cmd record: Add --daemonize
>   trace-cmd: export pidfile functions from trace-listen.c
>   trace-cmd record: Create a pidfile when using --daemonize
>   trace-cmd record: Add --daemonize example to man page
> 
>  .../trace-cmd/trace-cmd-record.1.txt          |  33 ++++
>  tracecmd/include/trace-local.h                |   4 +
>  tracecmd/trace-listen.c                       |  32 ++--
>  tracecmd/trace-record.c                       | 142 +++++++++++++++++-
>  tracecmd/trace-usage.c                        |   3 +
>  5 files changed, 194 insertions(+), 20 deletions(-)
> 


      parent reply	other threads:[~2023-07-02  1:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-01 20:31 [PATCH 0/3] trace-cmd record: Support daemonization after recording starts avidanborisov
2023-05-01 20:31 ` [PATCH 1/3] trace-cmd record: Add --daemonize avidanborisov
2023-05-30  8:55   ` Steven Rostedt
2023-05-01 20:31 ` [PATCH 2/3] trace-cmd: export pidfile functions from trace-listen.c avidanborisov
2023-05-01 20:31 ` [PATCH 3/3] trace-cmd record: Create a pidfile when using --daemonize avidanborisov
2023-05-30  8:51 ` [PATCH 0/3] trace-cmd record: Support daemonization after recording starts Steven Rostedt
2023-06-26  9:16   ` [PATCH v2 0/4] trace-cmd record: Improvements to --daemonize option avidanborisov
2023-06-26  9:16     ` [PATCH v2 1/4] trace-cmd record: Add --daemonize avidanborisov
2023-07-06  0:13       ` Steven Rostedt
2023-07-06  0:19       ` Steven Rostedt
2023-06-26  9:16     ` [PATCH v2 2/4] trace-cmd: export pidfile functions from trace-listen.c avidanborisov
2023-06-26  9:16     ` [PATCH v2 3/4] trace-cmd record: Create a pidfile when using --daemonize avidanborisov
2023-06-26  9:16     ` [PATCH v2 4/4] trace-cmd record: Add --daemonize example to man page avidanborisov
2023-07-02  1:39     ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230701213915.482b5ff6@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=avidanborisov@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).