From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
dan.carpenter@linaro.org, linux-trace-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kernel/trace: Fix cleanup logic of enable_trace_eprobe
Date: Wed, 5 Jul 2023 11:05:34 -0400 [thread overview]
Message-ID: <20230705110534.1b79bf79@gandalf.local.home> (raw)
In-Reply-To: <20230705110302.2492a550@gandalf.local.home>
On Wed, 5 Jul 2023 11:03:02 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 3 Jul 2023 06:47:12 +0300
> Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
>
> > Ok, I'll send v3 with the counter, although I think it is a bit
> > overengineering - that optimization is in code that is unlikely to be
> > executed.
>
> It's not really over-engineering. We have this type of logic all over the
> kernel. When rolling back something, you really only want to rollback what
> you did, and not more. It prevents future bugs and makes things a bit more
> robust.
>
> I'll go pick up v3 now.
>
Masami, I see you delegated this patch to yourself. If you have something
you are working on to send to Linus soon, I'll let you take it.
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
prev parent reply other threads:[~2023-07-05 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 12:16 [PATCH v2] kernel/trace: Fix cleanup logic of enable_trace_eprobe Tzvetomir Stoyanov (VMware)
2023-07-01 13:02 ` Steven Rostedt
2023-07-02 14:50 ` Masami Hiramatsu
2023-07-03 3:47 ` Tzvetomir Stoyanov
2023-07-05 15:03 ` Steven Rostedt
2023-07-05 15:05 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705110534.1b79bf79@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).