From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12263C001DE for ; Wed, 5 Jul 2023 15:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232994AbjGEPFt (ORCPT ); Wed, 5 Jul 2023 11:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233036AbjGEPFs (ORCPT ); Wed, 5 Jul 2023 11:05:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A1331998; Wed, 5 Jul 2023 08:05:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D0E78615C9; Wed, 5 Jul 2023 15:05:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4CD7C433C7; Wed, 5 Jul 2023 15:05:35 +0000 (UTC) Date: Wed, 5 Jul 2023 11:05:34 -0400 From: Steven Rostedt To: Tzvetomir Stoyanov Cc: Masami Hiramatsu , dan.carpenter@linaro.org, linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] kernel/trace: Fix cleanup logic of enable_trace_eprobe Message-ID: <20230705110534.1b79bf79@gandalf.local.home> In-Reply-To: <20230705110302.2492a550@gandalf.local.home> References: <20230630121627.833560-1-tz.stoyanov@gmail.com> <20230701090254.72323659@rorschach.local.home> <20230702235001.5bd26b8cd85028fc2bce94e6@kernel.org> <20230705110302.2492a550@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Wed, 5 Jul 2023 11:03:02 -0400 Steven Rostedt wrote: > On Mon, 3 Jul 2023 06:47:12 +0300 > Tzvetomir Stoyanov wrote: > > > Ok, I'll send v3 with the counter, although I think it is a bit > > overengineering - that optimization is in code that is unlikely to be > > executed. > > It's not really over-engineering. We have this type of logic all over the > kernel. When rolling back something, you really only want to rollback what > you did, and not more. It prevents future bugs and makes things a bit more > robust. > > I'll go pick up v3 now. > Masami, I see you delegated this patch to yourself. If you have something you are working on to send to Linus soon, I'll let you take it. Reviewed-by: Steven Rostedt (Google) -- Steve