From: Steven Rostedt <rostedt@goodmis.org>
To: avidanborisov@gmail.com
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] trace-cmd record: Add --daemonize
Date: Wed, 5 Jul 2023 20:13:00 -0400 [thread overview]
Message-ID: <20230705201300.006a5a14@gandalf.local.home> (raw)
In-Reply-To: <20230626091635.3002827-2-avidanborisov@gmail.com>
On Mon, 26 Jun 2023 12:16:32 +0300
avidanborisov@gmail.com wrote:
> + if (do_daemonize) {
> + daemonize_finish();
> + printf("Send SIGINT to pid %d to stop recording\n", getpid());
I wonder if we should also add SIGTERM, as that's the default signal used by "kill".
It would suck to have a nice trace going and then execute "kill $pid" only
to find out it killed the process and didn't finish processing it.
-- Steve
> + } else {
> + /* sleep till we are woken with Ctrl^C */
> + printf("Hit Ctrl^C to stop recording\n");
> + }
next prev parent reply other threads:[~2023-07-06 0:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 20:31 [PATCH 0/3] trace-cmd record: Support daemonization after recording starts avidanborisov
2023-05-01 20:31 ` [PATCH 1/3] trace-cmd record: Add --daemonize avidanborisov
2023-05-30 8:55 ` Steven Rostedt
2023-05-01 20:31 ` [PATCH 2/3] trace-cmd: export pidfile functions from trace-listen.c avidanborisov
2023-05-01 20:31 ` [PATCH 3/3] trace-cmd record: Create a pidfile when using --daemonize avidanborisov
2023-05-30 8:51 ` [PATCH 0/3] trace-cmd record: Support daemonization after recording starts Steven Rostedt
2023-06-26 9:16 ` [PATCH v2 0/4] trace-cmd record: Improvements to --daemonize option avidanborisov
2023-06-26 9:16 ` [PATCH v2 1/4] trace-cmd record: Add --daemonize avidanborisov
2023-07-06 0:13 ` Steven Rostedt [this message]
2023-07-06 0:19 ` Steven Rostedt
2023-06-26 9:16 ` [PATCH v2 2/4] trace-cmd: export pidfile functions from trace-listen.c avidanborisov
2023-06-26 9:16 ` [PATCH v2 3/4] trace-cmd record: Create a pidfile when using --daemonize avidanborisov
2023-06-26 9:16 ` [PATCH v2 4/4] trace-cmd record: Add --daemonize example to man page avidanborisov
2023-07-02 1:39 ` [PATCH v2 0/4] trace-cmd record: Improvements to --daemonize option Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705201300.006a5a14@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=avidanborisov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).