From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtracefs: Fix documentation of tracefs_trace_pipe_stream() flags
Date: Wed, 5 Jul 2023 21:53:51 -0400 [thread overview]
Message-ID: <20230705215351.2fe04ea0@gandalf.local.home> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
The flags description in the man page of tracefs_trace_pipe_stream() is
not detailed enough. Not only does it just say "(see )" without saying
"open(2)", it needs a bit more description about how it is used, as it is
not exactly like open(2).
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
Documentation/libtracefs-stream.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/libtracefs-stream.txt b/Documentation/libtracefs-stream.txt
index 8008be810a33..7f1ff6aca4e6 100644
--- a/Documentation/libtracefs-stream.txt
+++ b/Documentation/libtracefs-stream.txt
@@ -31,8 +31,9 @@ The *tracefs_trace_pipe_stream()* function redirects the stream of trace data to
file. The "splice" system call is used to moves the data without copying between kernel
address space and user address space. The _fd_ is the file descriptor of the output file
and _flags_ is a bit mask of flags to be passed to the open system call of the trace_pipe
-file (see ). If flags contain O_NONBLOCK, then that is also passed to the splice calls
-that may read the file to the output stream file descriptor.
+file (see *open(2)*). If flags contain O_NONBLOCK, then that is also passed to the splice calls
+that may read the file to the output stream file descriptor. Note, O_RDONLY is or'd to
+the _flags_ and only O_NONBLOCK is useful for this parameter.
The *tracefs_trace_pipe_print()* function is similar to *tracefs_trace_pipe_stream()*, but
the stream of trace data is redirected to stdout.
--
2.39.2
reply other threads:[~2023-07-06 1:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705215351.2fe04ea0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).