* [PATCH] libtraceeval: fix cscope makefile rule
@ 2023-08-02 17:16 Ross Zwisler
0 siblings, 0 replies; only message in thread
From: Ross Zwisler @ 2023-08-02 17:16 UTC (permalink / raw)
To: linux-trace-devel; +Cc: Ross Zwisler, Stevie Alvarez (Google), Steven Rostedt
From: Ross Zwisler <zwisler@google.com>
The current 'make cscope' rule does not actually pass the filenames
gathered by 'find' to cscope. cscope expects them either to be passed
on the command line, as this patch does with xargs, or via a
'cscope.files' intermediate file. It doesn't read them from stdin.
As long as the file count is low, as it is in this library, the command
line version works fine. Larger projects like the kernel need to use
the intermediate file.
Signed-off-by: Ross Zwisler <zwisler@google.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 3ea051c..5779c43 100644
--- a/Makefile
+++ b/Makefile
@@ -230,7 +230,7 @@ $(EMACS_TAGS): force
$(CSCOPE_TAGS): force
$(RM) $(obj)/cscope*
- $(call find_tag_files) | cscope -b -q
+ $(call find_tag_files) | xargs cscope -b -q
tags: $(VIM_TAGS)
TAGS: $(EMACS_TAGS)
--
2.41.0.585.gd2178a4bd4-goog
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-08-02 17:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-02 17:16 [PATCH] libtraceeval: fix cscope makefile rule Ross Zwisler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).