From: Steven Rostedt <rostedt@goodmis.org>
To: Ze Gao <zegao2021@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>, Ingo Molnar <mingo@redhat.com>,
Jiri Olsa <jolsa@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
linux-trace-devel@vger.kernel.org, Ze Gao <zegao@tencent.com>
Subject: Re: [RFC PATCH v4 5/7] sched, tracing: add to report task state in symbolic chars
Date: Wed, 2 Aug 2023 22:48:49 -0400 [thread overview]
Message-ID: <20230802224849.215b96b0@gandalf.local.home> (raw)
In-Reply-To: <CAD8CoPDUkUOc8_p8Ygnoy6xfQZtPhiDDPgnhTMfoEtmrQFRwMw@mail.gmail.com>
On Thu, 3 Aug 2023 10:38:43 +0800
Ze Gao <zegao2021@gmail.com> wrote:
> > > +static inline char __trace_sched_switch_state_char(bool preempt,
> > > + unsigned int prev_state,
> > > + struct task_struct *p)
> > > +{
> > > + long state;
> > > +
> > > +#ifdef CONFIG_SCHED_DEBUG
> > > + BUG_ON(p != current);
> >
> > BUG? Why not WARN_ON()?
>
> I directly copied it from __trace_sched_switch_state since they
> are very similar. I had doubt on this too but decided to keep it in
> case people want to be 100% sure that the current task is exactly
> the one that is being switched, otherwise it's a fatal problem for
> scheduler at the point where trace_sched_switch is called.
>
> If you think WARN_ON_ONCE is more appropriate, I can fix both
> in v6.
>
> Thoughts?
Yeah, that BUG_ON is from 2014, and really should not BUG.
I'd fix both.
Thanks!
-- Steve
next prev parent reply other threads:[~2023-08-03 2:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 12:09 [RFC PATCH v4 0/7] fix task state report from sched tracepoint Ze Gao
2023-08-02 12:09 ` [RFC PATCH v4 1/7] libtraceevent: sync state char array with the kernel Ze Gao
2023-08-02 14:36 ` Steven Rostedt
2023-08-03 2:13 ` Ze Gao
2023-08-03 2:37 ` Steven Rostedt
2023-08-03 2:49 ` Ze Gao
2023-08-02 12:09 ` [RFC PATCH v4 2/7] perf sched: " Ze Gao
2023-08-02 12:09 ` [RFC PATCH v4 3/7] perf sched: reorganize sched-out task state report code Ze Gao
2023-08-02 12:09 ` [RFC PATCH v4 4/7] sched, tracing: reorganize fields of switch event struct Ze Gao
2023-08-02 15:05 ` Steven Rostedt
2023-08-03 2:02 ` Ze Gao
2023-08-02 12:10 ` [RFC PATCH v4 5/7] sched, tracing: add to report task state in symbolic chars Ze Gao
2023-08-02 15:07 ` Steven Rostedt
2023-08-03 2:38 ` Ze Gao
2023-08-03 2:48 ` Steven Rostedt [this message]
2023-08-02 12:10 ` [RFC PATCH v4 6/7] perf sched: prefer to use prev_state_char introduced in sched_switch Ze Gao
2023-08-02 12:10 ` [RFC PATCH v4 7/7] libtraceevent: " Ze Gao
2023-08-02 15:08 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802224849.215b96b0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zegao2021@gmail.com \
--cc=zegao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).