[PATCH] traceeval: Remove free_results()

[PATCH] traceeval: Remove free_results()

[Steven Rostedt]

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The static function free_results() was never used. I kept it around for
when I was going to add it (and to remind myself not to forgot about it,
which is why I left the warning). But now that the code is being
rewritten, there's no more need to keep he warning around to remind me to
attach it. Get rid of it, all that code is going away anyway.

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 src/trace-analysis.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/trace-analysis.c b/src/trace-analysis.c
index 0f68b9941b1e..ba4e1c75d634 100644
--- a/src/trace-analysis.c
+++ b/src/trace-analysis.c
@@ -197,12 +197,6 @@ static int cmp_keys(struct traceeval_key_info_array *tarray,
 	return 0;
 }
 
-static void free_results (struct traceeval *teval)
-{
-	free(teval->results);
-	teval->results = NULL;
-}
-
 static int make_key(struct traceeval *teval, const struct traceeval_key *keys, int *err)
 {
 	struct traceeval_key_info *kinfo;
-- 
2.40.1

Re: [PATCH] traceeval: Remove free_results()

[Ross Zwisler]

On Fri, Aug 04, 2023 at 09:52:19AM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
> 
> The static function free_results() was never used. I kept it around for
> when I was going to add it (and to remind myself not to forgot about it,
> which is why I left the warning). But now that the code is being
> rewritten, there's no more need to keep he warning around to remind me to
> attach it. Get rid of it, all that code is going away anyway.
> 
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Reviewed-by: Ross Zwisler <zwisler@google.com>