From: Steven Rostedt <rostedt@goodmis.org>
To: Stevie Alvarez <stevie.6strings@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, Ross Zwisler <zwisler@google.com>
Subject: Re: [PATCH v4 4/5] histograms: Add traceeval query
Date: Wed, 9 Aug 2023 15:57:43 -0400 [thread overview]
Message-ID: <20230809155743.0c72fe80@gandalf.local.home> (raw)
In-Reply-To: <20230809175340.3066-5-stevie.6strings@gmail.com>
On Wed, 9 Aug 2023 13:53:37 -0400
Stevie Alvarez <stevie.6strings@gmail.com> wrote:
> +static int copy_traceeval_data_set(size_t size, struct traceeval_type *type,
> + const union traceeval_data *orig,
> + union traceeval_data **copy)
> +{
> + size_t i;
> +
> + *copy = NULL;
> + if (!size)
> + return 1;
> +
> + *copy = calloc(size, sizeof(**copy));
> + if (!*copy)
> + return -1;
> +
> + for (i = 0; i < size; i++) {
> + if (copy_traceeval_data(type + i, orig + i, (*copy) + i))
> + goto fail;
> + }
> +
> + return 1;
> +
> +fail:
> + data_release(i, copy, type);
> + return -1;
> +}
I think Ross mentioned this too, but we should have a copy() callback to
allow things like the dyn events to be copied.
-- Steve
next prev parent reply other threads:[~2023-08-09 19:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 17:53 [PATCH v4 0/5] histograms: Fix memory leak, logic bugs, legibility Stevie Alvarez
2023-08-09 17:53 ` [PATCH v4 1/5] histograms: Initial histograms interface Stevie Alvarez
2023-08-09 18:53 ` Steven Rostedt
2023-08-09 17:53 ` [PATCH v4 2/5] histograms: Add traceeval initialize and release Stevie Alvarez
2023-08-09 19:04 ` Steven Rostedt
2023-08-09 17:53 ` [PATCH v4 3/5] histograms: Add traceeval compare Stevie Alvarez
2023-08-09 17:53 ` [PATCH v4 4/5] histograms: Add traceeval query Stevie Alvarez
2023-08-09 19:57 ` Steven Rostedt [this message]
2023-08-11 2:00 ` Steven Rostedt
2023-08-09 17:53 ` [PATCH v4 5/5] histograms: Add traceeval insert Stevie Alvarez
2023-08-10 2:57 ` Steven Rostedt
2023-08-09 18:30 ` [PATCH v4 0/5] histograms: Fix memory leak, logic bugs, legibility Steven Rostedt
2023-08-10 21:16 ` Ross Zwisler
2023-08-17 22:08 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809155743.0c72fe80@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=stevie.6strings@gmail.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).