Re: [PATCH v3 14/18] libtraceeval histogram: Use stack for old copy in update

[Steven Rostedt <rostedt@goodmis.org>]

On Thu, 17 Aug 2023 13:44:59 -0600
Ross Zwisler <zwisler@google.com> wrote:

> > I need to change the parameter names to "src" and "dst" as I can't think of
> > "orig" and "copy" as which direction they go.   
> 
> I was thinking the same thing, 'src' and 'dst' would be better. :)

and to make it even more confusing, I made made the compare callback
function ordering that of "copy, orig" ("dst, src")

 typedef int (*traceeval_data_copy_fn)(const struct traceeval_type *type,
                                     union traceeval_data *copy,
                                     const union traceeval_data *origin);

I've just updated my next version to start out by reversing the order of
the copy and to call it "dst" and "src", and I renamed
copy_traceveal_data_set() to dup_traceeval_data_set(), as it's just
duplicating the set, and not really "copying" it (think strdup()), as it
needs to allocate it. That way, I can keep the order, as duplication
variables should come at the end. And this will remove the ambiguity of the
copy order.

-- Steve