Re: [PATCH] libtraceevent: add option to disable documentation

[Steven Rostedt <rostedt@goodmis.org>]

On Sat, 30 Sep 2023 22:13:39 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

Hi Giulio,

Thanks for the patch, but could you please add a change log to explain
why this patch is needed? I'm not saying it isn't but I'd like to know
the rational for disabling documentation.

Thanks,

-- Steve


> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  meson.build       | 3 +++
>  meson_options.txt | 2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index b61c873..9a18e02 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -45,6 +45,8 @@ if cunit_dep.found()
>      subdir('utest')
>  endif
>  subdir('samples')
> +
> +if get_option('doc')
>  subdir('Documentation')
>  
>  custom_target(
> @@ -52,3 +54,4 @@ custom_target(
>      output: 'docs',
>      depends: [html, man],
>      command: ['echo'])
> +endif
> diff --git a/meson_options.txt b/meson_options.txt
> index b2294f6..9a40dad 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -16,3 +16,5 @@ option('man-bold-literal', type : 'boolean', value : false,
>         description : 'enable bold literals')
>  option('docbook-suppress-sp', type : 'boolean', value : false,
>         description : 'docbook suppress sp')
> +option('doc', type : 'boolean', value: true,
> +       description : 'produce documentation')