From: Ross Zwisler <zwisler@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
Stevie Alvarez <stevie.6strings@gmail.com>
Subject: Re: [PATCH v2] libtraceeval: Fix traceeval_insert() macro for NULL vals
Date: Mon, 2 Oct 2023 14:45:07 -0600 [thread overview]
Message-ID: <20231002204507.GL1532181@google.com> (raw)
In-Reply-To: <20230929051304.7b157905@rorschach.local.home>
On Fri, Sep 29, 2023 at 05:13:04AM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> If the vals is NULL (which is valid), the traceeval_insert() macro calls
> traceeval_insert_size() with sizeof(vals)/sizeof(vals[0]) to get the
> number of vals in the array. But this does not make sense with a NULL
> value. Check for NULL and if vals is NULL then pass in zero.
>
> Cc: Ross Zwisler <zwisler@google.com>
> Cc: Stevie Alvarez <stevie.6strings@gmail.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Reviewed-by: Ross Zwisler <zwisler@google.com>
prev parent reply other threads:[~2023-10-02 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 9:13 [PATCH v2] libtraceeval: Fix traceeval_insert() macro for NULL vals Steven Rostedt
2023-10-02 20:45 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002204507.GL1532181@google.com \
--to=zwisler@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stevie.6strings@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).