From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtracefs: Free "followers" when freeing instance
Date: Wed, 11 Oct 2023 22:30:31 -0400 [thread overview]
Message-ID: <20231011223031.0aa32a57@gandalf.local.home> (raw)
|From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
While running valgrind on an application that uses libtracefs, it revealed
that "followers" from tracefs_follow_event() is not freed if called for an
instance when the instance is freed.
Free it!
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
src/tracefs-instance.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/tracefs-instance.c b/src/tracefs-instance.c
index b3ed983db0e8..be1478ee7a92 100644
--- a/src/tracefs-instance.c
+++ b/src/tracefs-instance.c
@@ -123,6 +123,7 @@ __hidden void trace_put_instance(struct tracefs_instance *instance)
close(instance->ftrace_marker_raw_fd);
free(instance->trace_dir);
+ free(instance->followers);
free(instance->name);
pthread_mutex_destroy(&instance->lock);
free(instance);
--
2.42.0
reply other threads:[~2023-10-12 2:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011223031.0aa32a57@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).