Re: [PATCH 2/2] trace-cmd: Add ftrace options with fgraph retval option

[Steven Rostedt <rostedt@goodmis.org>]

Finally got the time to look at these patches ;-)

On Mon, 15 Apr 2024 08:49:21 -0700
Jianfeng Wang <jianfeng.w.wang@oracle.com> wrote:

> +++ b/lib/trace-cmd/trace-ftrace.c
> @@ -23,6 +23,12 @@ struct tep_plugin_option trace_ftrace_options[] = {
>  		.description =
>  		"Show the depth of each entry",
>  	},
> +	{
> +		.name = "retval",
> +		.plugin_alias = "fgraph",
> +		.description =
> +		"Print function retval at function exit in function graph",
> +	},

Honestly, I don't think this should be an option. Or if it is, it
should be default on. If the retval exists in the trace, it should just
be printed. Why ask the user to show it when they spent the time to
enable it in the recording?

Thanks!

-- Steve

>  	{
>  		.name = NULL,
>  	}