From: Steven Rostedt <rostedt@goodmis.org>
To: Metin Kaya <metin.kaya@arm.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] trace-cmd reset: Add option to preserve specific events
Date: Mon, 14 Oct 2024 17:59:05 -0400 [thread overview]
Message-ID: <20241014175905.03bec85a@gandalf.local.home> (raw)
In-Reply-To: <20241014123136.3890807-1-metin.kaya@arm.com>
On Mon, 14 Oct 2024 13:31:32 +0100
Metin Kaya <metin.kaya@arm.com> wrote:
> Changes since v1:
> - Update man page for -k command line parameter of "trace-cmd reset".
> - Add tab completion support for "trace-cmd reset".
Thanks, I'll go ahead and apply this. But can you do me a favor, and add a
test case to utest/tracecmd-utest.c that tests this. It should create a
each of the types, start tracing, do the reset, and make sure that the -k
keeps what is expected. Doesn't need to be too fancy.
I want to add test cases to all new features, as I'm way behind in testing
current features :-p
You don't need to send another version of this series. Just a standalone patch.
-- Steve
next prev parent reply other threads:[~2024-10-14 21:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 12:31 [PATCH v2 0/4] trace-cmd reset: Add option to preserve specific events Metin Kaya
2024-10-14 12:31 ` [PATCH v2 1/4] trace-cmd reset: Bail out immediately if user provides an invalid option Metin Kaya
2024-10-14 12:31 ` [PATCH v2 2/4] trace-cmd reset: Add option to preserve specific dynamic events Metin Kaya
2024-10-14 12:31 ` [PATCH v2 3/4] trace-cmd reset: Update man page for -k option Metin Kaya
2024-10-14 12:31 ` [PATCH v2 4/4] trace-cmd reset: Add bash tab completion for -B and -k Metin Kaya
2024-10-14 21:59 ` Steven Rostedt [this message]
2024-10-15 13:30 ` [PATCH v2 0/4] trace-cmd reset: Add option to preserve specific events Metin Kaya
2024-10-15 13:47 ` Steven Rostedt
2024-10-15 16:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014175905.03bec85a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=metin.kaya@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).