From: Steven Rostedt <rostedt@goodmis.org>
To: Metin Kaya <metin.kaya@arm.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] libtracefs: Destroy synthetic and eprobes before other events
Date: Thu, 17 Oct 2024 16:01:08 -0400 [thread overview]
Message-ID: <20241017160108.4f99c917@gandalf.local.home> (raw)
In-Reply-To: <e6ddd9b6-ce83-451e-8344-24ff620245cc@arm.com>
On Thu, 17 Oct 2024 09:38:35 +0100
Metin Kaya <metin.kaya@arm.com> wrote:
> I see one more failure in this section of unit tests:
>
> Test: tracefs_iterate_snapshot_events API ...FAILED
> 1. tracefs-utest.c:235 - ret == sizeof(struct test_sample)
> 2. tracefs-utest.c:235 - ret == sizeof(struct test_sample)
> 3. tracefs-utest.c:235 - ret == sizeof(struct test_sample)
>
Does this occur without this patch? IOW, is this caused by this patch?
> I did run trace-cmd reset and unmounted my tracefs before running the
> unit tests.
> Please feel free to ignore if something is weirdly wrong in my setup.
>
> Other than that -kind of existing- failure, the patch looks good to me
> (e.g., trace-cmd unit tests are working fine).
Can you add a printf("ret = %d\n", ret) to find out what "ret" is?
Thanks,
-- Steve
next prev parent reply other threads:[~2024-10-17 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 16:35 [PATCH] libtracefs: Destroy synthetic and eprobes before other events Steven Rostedt
2024-10-17 8:38 ` Metin Kaya
2024-10-17 20:01 ` Steven Rostedt [this message]
2024-10-18 9:13 ` Metin Kaya
2024-10-18 14:17 ` Steven Rostedt
2024-10-18 14:51 ` Metin Kaya
2024-11-20 3:57 ` Steven Rostedt
2024-11-20 7:42 ` Metin Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017160108.4f99c917@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=metin.kaya@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).