From: Steven Rostedt <rostedt@goodmis.org>
To: Metin Kaya <metin.kaya@arm.com>
Cc: linux-trace-devel@vger.kernel.org,
Douglas Raillard <douglas.raillard@arm.com>
Subject: Re: [PATCH] trace-cmd: libtracecmd: Rename private functions to fix static building
Date: Thu, 31 Oct 2024 11:40:42 -0400 [thread overview]
Message-ID: <20241031114042.7b43ec0e@gandalf.local.home> (raw)
In-Reply-To: <d95d6af4-75bb-44da-a479-045556141559@arm.com>
On Thu, 31 Oct 2024 09:48:32 +0000
Metin Kaya <metin.kaya@arm.com> wrote:
> > As for libtraceevent, it doesn't need a separate prefix for local
> > variables compared to exported ones, but that prefix is "tep_" and not
> > "traceevent_".
>
> I believe I did not rename any variables in the libtraceevent patch [1].
> However, I made the following changes in the libtracefs patch [2]:
>
> -extern const struct tep_format_field common_stacktrace;
> +extern const struct tep_format_field tracefs_common_stacktrace;
>
> -extern pthread_mutex_t toplevel_lock;
> +extern pthread_mutex_t tracefs_toplevel_lock;
>
> Do you recommend keeping them as is or using "tfs_" prefix?
Might as well make the change. At least that tells us it's exposed across
files in the library.
-- Steve
prev parent reply other threads:[~2024-10-31 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 12:22 [PATCH] trace-cmd: libtracecmd: Rename private functions to fix static building Metin Kaya
2024-10-31 0:47 ` Steven Rostedt
2024-10-31 9:48 ` Metin Kaya
2024-10-31 15:40 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031114042.7b43ec0e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=douglas.raillard@arm.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=metin.kaya@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).