* [PATCH] trace-cmd completion: Fix trace-cmd report to show files
@ 2025-04-17 0:12 Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2025-04-17 0:12 UTC (permalink / raw)
To: Linux Trace Devel
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
The addition of the trace-cmd sqlhist had to separate out where commands
are printed and where files are printed, and it split cmd_options into one
that showed the commands and cmd_options_files that also will show the
files if no command was found to be completed.
Some trace-cmd commands should show files and some should not.
trace-cmd report is one that should show files if nothing else is
completed, but it was given cmd_options when it should have used
cmd_options_files.
Fixes: 2149da9cdc48b ("trace-cmd: Add sqlhist to bash completion")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
tracecmd/trace-cmd.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tracecmd/trace-cmd.bash b/tracecmd/trace-cmd.bash
index 82a3b91dfd02..a7e81e0ded4a 100644
--- a/tracecmd/trace-cmd.bash
+++ b/tracecmd/trace-cmd.bash
@@ -237,7 +237,7 @@ __trace_cmd_report_complete()
plugin_options "$cur"
;;
*)
- cmd_options report "$cur"
+ cmd_options_files report "$cur"
;;
esac
}
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] trace-cmd completion: Fix trace-cmd report to show files
@ 2025-05-30 19:45 Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2025-05-30 19:45 UTC (permalink / raw)
To: Linux Trace Devel
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
The addition of the trace-cmd sqlhist had to separate out where commands
are printed and where files are printed, and it split cmd_options into one
that showed the commands and cmd_options_files that also will show the
files if no command was found to be completed.
Some trace-cmd commands should show files and some should not.
trace-cmd report is one that should show files if nothing else is
completed, but it was given cmd_options when it should have used
cmd_options_files.
Fixes: 2149da9cdc48b ("trace-cmd: Add sqlhist to bash completion")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
tracecmd/trace-cmd.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tracecmd/trace-cmd.bash b/tracecmd/trace-cmd.bash
index 82a3b91dfd02..a7e81e0ded4a 100644
--- a/tracecmd/trace-cmd.bash
+++ b/tracecmd/trace-cmd.bash
@@ -237,7 +237,7 @@ __trace_cmd_report_complete()
plugin_options "$cur"
;;
*)
- cmd_options report "$cur"
+ cmd_options_files report "$cur"
;;
esac
}
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-30 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-17 0:12 [PATCH] trace-cmd completion: Fix trace-cmd report to show files Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2025-05-30 19:45 Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).