From: Steven Rostedt <rostedt@goodmis.org>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Linux Trace Devel Mailing List
<linux-trace-devel@vger.kernel.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Subject: Re: [PATCH 0/2] ccli: Two small fixes for ccli
Date: Wed, 20 Aug 2025 20:12:36 -0400 [thread overview]
Message-ID: <20250820201236.3f685799@gandalf.local.home> (raw)
In-Reply-To: <20250820211434.1857859-1-ammarfaizi2@gnuweeb.org>
On Thu, 21 Aug 2025 04:14:32 +0700
Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> Hi Steve,
Hi Ammar!
>
> Alviro and I found two small issues in the ccli code.
There's a famous Linux kernel developer named Al Viro, and when I saw the
name Alviro, I was confused and was wondering why Al was working with you.
But then I saw the Cc list ;-)
>
> The first one is a warning about uninitialized variable in the cache
> code. The second one is an optimization issue found when clang warns
> about unused return value of strlen() calls.
>
> Fix them.
>
> Ammar Faizi (2):
> ccli: cache: Fix -Wuninitialized warning
> ccli: commands: Fix optimized `strlen()` calls
Thanks for the updates!
FYI, I'm relicensing libccli under MIT from LGPL. Are you OK with that?
Cheers,
-- Steve
>
> src/cache.c | 3 +--
> src/ccli-local.h | 1 +
> src/commands.c | 1 +
> 3 files changed, 3 insertions(+), 2 deletions(-)
>
>
> base-commit: 418ad6a341a5ab6c21be666565d62a878aa3bd18
next prev parent reply other threads:[~2025-08-21 0:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 21:14 [PATCH 0/2] ccli: Two small fixes for ccli Ammar Faizi
2025-08-20 21:14 ` [PATCH 1/2] ccli: cache: Fix -Wuninitialized warning Ammar Faizi
2025-08-20 21:14 ` [PATCH 2/2] ccli: commands: Fix optimized `strlen()` calls Ammar Faizi
2025-08-21 0:12 ` Steven Rostedt [this message]
2025-08-21 0:15 ` [PATCH 0/2] ccli: Two small fixes for ccli Ammar Faizi
2025-08-21 0:18 ` Steven Rostedt
2025-08-21 0:23 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820201236.3f685799@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).