From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtracefs utest: Update kprobe test to use filename_mkdirat
Date: Fri, 29 May 2026 15:30:23 -0400 [thread overview]
Message-ID: <20260529153023.440b966c@fedora> (raw)
From: Steven Rostedt <rostedt@goodmis.org>
The function do_mkdirat was renamed to filename_mkdirat. Ideally, this would
check if the filename_mkdirat exists and if not, fallback to do_mkdirat. But
that would just add complexity to a test that should be called on the most
recent kernels anyway. If it does become an issue, we can add the
complexity and make it more robust.
Perhaps a check should be done to make sure each function exists before
testing it.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
utest/tracefs-utest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/utest/tracefs-utest.c b/utest/tracefs-utest.c
index e3ff215..05cbc95 100644
--- a/utest/tracefs-utest.c
+++ b/utest/tracefs-utest.c
@@ -2289,7 +2289,7 @@ static bool check_probes(struct probe_test *probes, int count,
static void test_kprobes_instance(struct tracefs_instance *instance)
{
struct probe_test ktests[] = {
- { TRACEFS_DYNEVENT_KPROBE, "p", NULL, "mkdir", "do_mkdirat", "path=+u0($arg2):ustring" },
+ { TRACEFS_DYNEVENT_KPROBE, "p", NULL, "mkdir", "filename_mkdirat", "path=+u0($arg2):ustring" },
{ TRACEFS_DYNEVENT_KPROBE, "p", NULL, "close", "close_fd", NULL },
{ TRACEFS_DYNEVENT_KPROBE, "p", "ptest", "open2", "do_sys_openat2",
"file=+u0($arg2):ustring flags=+0($arg3):x64" },
@@ -2634,7 +2634,7 @@ static void test_multi_probes_instance(struct tracefs_instance *instance)
"file=+0($filename):ustring" },
{ TRACEFS_DYNEVENT_EPROBE, "e", "etest", "sopen_out", "syscalls.sys_exit_openat",
"res=$ret:u64" },
- { TRACEFS_DYNEVENT_KPROBE, "p", NULL, "mkdir", "do_mkdirat", "path=+u0($arg2):ustring" },
+ { TRACEFS_DYNEVENT_KPROBE, "p", NULL, "mkdir", "filename_mkdirat", "path=+u0($arg2):ustring" },
{ TRACEFS_DYNEVENT_KPROBE, "p", NULL, "close", "close_fd", NULL },
{ TRACEFS_DYNEVENT_KPROBE, "p", "ptest", "open2", "do_sys_openat2",
"file=+u0($arg2):ustring flags=+0($arg3):x64" },
--
2.51.0
reply other threads:[~2026-05-29 19:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529153023.440b966c@fedora \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox