From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Tao Zhou <tao.zhou@linux.dev>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Gabriele Paoloni <gpaoloni@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Clark Williams <williams@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH V5 04/16] rv/include: Add deterministic automata monitor definition via C macros
Date: Mon, 18 Jul 2022 09:54:16 +0200 [thread overview]
Message-ID: <26677d42-337c-8786-f10a-0d87a14ae15c@kernel.org> (raw)
In-Reply-To: <YtQoYMLHgvTV0lea@geo.homenetwork>
On 7/17/22 17:18, Tao Zhou wrote:
>> +static int task_mon_slot_##name = RV_PER_TASK_MONITOR_INIT; \
> In patch1, RV_PER_TASK_MONITOR_INIT is defined as:
>
> #define RV_PER_TASK_MONITORS 1
> #define RV_PER_TASK_MONITOR_INIT (RV_PER_TASK_MONITORS)
>
> RV_PER_TASK_MONITOR_INIT is 1 now, seems not the index of the first only
> element in vector. Now no map here, one task has one monitor though if I
> am not wrong.
> So task_mon_slot_##name must be defined to the index of first element.
> Modify the macro definition of RV_PER_TASK_MONITOR_INIT to the index of
> first element in vector.
>
> #define RV_PER_TASK_MONITOR_INIT (RV_PER_TASK_MONITORS) - 1
nop, (RV_PER_TASK_MONITORS) is an invalid vector value, so we can detect things like:
disabling a disabled monitor.
(I forgot to reset it when disabling a monitor... added)
-- Daniel
next prev parent reply other threads:[~2022-07-18 7:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 21:17 [PATCH V5 00/16] The Runtime Verification (RV) interface Daniel Bristot de Oliveira
2022-07-13 21:17 ` [PATCH V5 01/16] rv: Add " Daniel Bristot de Oliveira
2022-07-14 7:46 ` Tao Zhou
2022-07-15 11:47 ` Daniel Bristot de Oliveira
2022-07-15 13:48 ` Tao Zhou
2022-07-13 21:17 ` [PATCH V5 02/16] rv: Add runtime reactors interface Daniel Bristot de Oliveira
2022-07-17 15:29 ` Tao Zhou
2022-07-17 18:56 ` kernel test robot
2022-07-13 21:17 ` [PATCH V5 03/16] rv/include: Add helper functions for deterministic automata Daniel Bristot de Oliveira
2022-07-13 21:17 ` [PATCH V5 04/16] rv/include: Add deterministic automata monitor definition via C macros Daniel Bristot de Oliveira
2022-07-17 15:18 ` Tao Zhou
2022-07-18 7:54 ` Daniel Bristot de Oliveira [this message]
2022-07-13 21:17 ` [PATCH V5 05/16] rv/include: Add instrumentation helper functions Daniel Bristot de Oliveira
2022-07-13 21:17 ` [PATCH V5 06/16] Documentation/rv: Add a basic documentation Daniel Bristot de Oliveira
2022-07-17 15:19 ` Tao Zhou
2022-07-13 21:17 ` [PATCH V5 07/16] tools/rv: Add dot2c Daniel Bristot de Oliveira
2022-07-13 21:17 ` [PATCH V5 08/16] Documentation/rv: Add deterministic automaton documentation Daniel Bristot de Oliveira
2022-07-13 21:17 ` [PATCH V5 09/16] tools/rv: Add dot2k Daniel Bristot de Oliveira
2022-07-13 21:17 ` [PATCH V5 10/16] Documentation/rv: Add deterministic automata monitor synthesis documentation Daniel Bristot de Oliveira
2022-07-13 21:17 ` [PATCH V5 11/16] Documentation/rv: Add deterministic automata instrumentation documentation Daniel Bristot de Oliveira
2022-07-17 15:20 ` Tao Zhou
2022-07-13 21:17 ` [PATCH V5 12/16] rv/monitor: Add the wip monitor skeleton created by dot2k Daniel Bristot de Oliveira
2022-07-13 21:17 ` [PATCH V5 13/16] rv/monitor: Add the wip monitor Daniel Bristot de Oliveira
2022-07-13 21:17 ` [PATCH V5 14/16] rv/monitor: Add the wwnr monitor Daniel Bristot de Oliveira
2022-07-13 21:17 ` [PATCH V5 15/16] rv/reactor: Add the printk reactor Daniel Bristot de Oliveira
2022-07-17 23:52 ` kernel test robot
2022-07-18 8:45 ` kernel test robot
2022-07-13 21:17 ` [PATCH V5 16/16] rv/reactor: Add the panic reactor Daniel Bristot de Oliveira
2022-07-18 2:05 ` kernel test robot
2022-07-18 11:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26677d42-337c-8786-f10a-0d87a14ae15c@kernel.org \
--to=bristot@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=gpaoloni@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=tao.zhou@linux.dev \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=williams@redhat.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).