From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD85BC43334 for ; Mon, 18 Jul 2022 07:54:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232115AbiGRHy1 (ORCPT ); Mon, 18 Jul 2022 03:54:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbiGRHy0 (ORCPT ); Mon, 18 Jul 2022 03:54:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0051D112F; Mon, 18 Jul 2022 00:54:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E96061366; Mon, 18 Jul 2022 07:54:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 418BCC341C0; Mon, 18 Jul 2022 07:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658130865; bh=tWt1vYWDaTVxwRFLqeGhQ6xsXw83LhS7SS6nHo2L++A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PGd1WO1dR1rdIH2fiN+CBoHkIbKQMUkLabEOE/zWsuFuZ6UuEGL7rkfudlsSYo1Jj gaG92VUCo+9XH9rhN5pikSlXD9kiu9dStrvLRufQfQYcgBzYIlZ07PvGRhkSKaUc/A 6OWULNC8ouxJIWUgNVDMwi0v+Fuje0GdSEtdzIUXWbFKpUQaKO85DgKp/ZkffoYctk J8dbil1nRSO99qGsF9sOuI8glmcDOTqmtnN5Ag7tu9AlJa2pKnmZoe85rvXbom5ezf nnhyXIVyrmGdsy3e3UFjGmzTSQHV9f3wRQO/8CPy+ZQPHdhCNKhvu/5AdIBknHs4og oJgIcck1Nyhvg== Message-ID: <26677d42-337c-8786-f10a-0d87a14ae15c@kernel.org> Date: Mon, 18 Jul 2022 09:54:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V5 04/16] rv/include: Add deterministic automata monitor definition via C macros Content-Language: en-US To: Tao Zhou Cc: Steven Rostedt , Wim Van Sebroeck , Guenter Roeck , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Will Deacon , Catalin Marinas , Marco Elver , Dmitry Vyukov , "Paul E. McKenney" , Shuah Khan , Gabriele Paoloni , Juri Lelli , Clark Williams , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org References: <5e0447aa9d114c52fd2bc335de036c61d9625f1c.1657745645.git.bristot@kernel.org> From: Daniel Bristot de Oliveira In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On 7/17/22 17:18, Tao Zhou wrote: >> +static int task_mon_slot_##name = RV_PER_TASK_MONITOR_INIT; \ > In patch1, RV_PER_TASK_MONITOR_INIT is defined as: > > #define RV_PER_TASK_MONITORS 1 > #define RV_PER_TASK_MONITOR_INIT (RV_PER_TASK_MONITORS) > > RV_PER_TASK_MONITOR_INIT is 1 now, seems not the index of the first only > element in vector. Now no map here, one task has one monitor though if I > am not wrong. > So task_mon_slot_##name must be defined to the index of first element. > Modify the macro definition of RV_PER_TASK_MONITOR_INIT to the index of > first element in vector. > > #define RV_PER_TASK_MONITOR_INIT (RV_PER_TASK_MONITORS) - 1 nop, (RV_PER_TASK_MONITORS) is an invalid vector value, so we can detect things like: disabling a disabled monitor. (I forgot to reset it when disabling a monitor... added) -- Daniel