linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yordan Karadzhov <y.karadz@gmail.com>
To: Daniel Wagner <dwagner@suse.de>, linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH kernelshark] kernel-shark: Build missed_event as GUI plugin
Date: Fri, 26 Aug 2022 18:20:53 +0300	[thread overview]
Message-ID: <2f68dfa2-81eb-d07c-75ae-1b79a9007a21@gmail.com> (raw)
In-Reply-To: <20220824135309.5347-1-dwagner@suse.de>

Thanks Daniel!
Yordan

On 8/24/22 16:53, Daniel Wagner wrote:
> missed_events depends on GUI elements hence it should be build as GUI
> plugin.
> 
> Signged-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> 
> I had some build errors due to global build flags in our build service:
> 
>    Linker flags : -flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now
> 
>   src/plugins/CMakeLists.txt | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/plugins/CMakeLists.txt b/src/plugins/CMakeLists.txt
> index e9d906863424..49aee3ed7560 100644
> --- a/src/plugins/CMakeLists.txt
> +++ b/src/plugins/CMakeLists.txt
> @@ -61,8 +61,8 @@ if (Qt5Widgets_FOUND AND TT_FONT_FILE)
>   
>   endif (Qt5Widgets_FOUND AND TT_FONT_FILE)
>   
> -BUILD_PLUGIN(NAME missed_events
> -             SOURCE missed_events.c MissedEvents.cpp)
> +BUILD_GUI_PLUGIN(NAME missed_events
> +		 SOURCE missed_events.c MissedEvents.cpp)
>   list(APPEND PLUGIN_LIST "missed_events")
>   
>   install(TARGETS ${PLUGIN_LIST}

      reply	other threads:[~2022-08-26 15:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 13:53 [PATCH kernelshark] kernel-shark: Build missed_event as GUI plugin Daniel Wagner
2022-08-26 15:20 ` Yordan Karadzhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f68dfa2-81eb-d07c-75ae-1b79a9007a21@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=dwagner@suse.de \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).