From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: Steven Rostedt <rostedt@goodmis.org>,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v3] kernel-shark: Define a CMAKE_BUILD_TYPE "Package"
Date: Mon, 8 Jul 2019 14:02:11 +0000 [thread overview]
Message-ID: <30a439a4-fd66-cbed-5c6d-08fa2af22a82@vmware.com> (raw)
In-Reply-To: <20190708092632.0062411b@gandalf.local.home>
On 8.07.19 г. 16:26 ч., Steven Rostedt wrote:
> On Mon, 8 Jul 2019 12:19:45 +0300
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
>
>> From: Yordan Karadzhov <ykaradzhov@vmware.com>
>>
>> A special build type dedicated for package maintainers is added.
>> By default this build type adds the "-O3" compiler flag. Users
>> can chose their own compiler flags by providing the corresponding
>> CMAKE_XXXX_FLAGS_PACKAGE Command-Line options.
>>
>> If no types is specified, the build type will be "Debug".
>>
>> Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
>>
>
> Thanks Yordan!
>
> I applied and pushed most your patches upstream.
>
> I started to play a little with the record feature, and found some
> issues.
>
> 1) It still adds a -e'event' for all events when a system is selected.
> Can we just make it use the system? -eirq instead of
> -eirq:irq_handler_entry -eirq:irq_handler_exit -eirq...
>
> 2) When I executed it, it gave me an error, and then crashed
> kernelshark. It should check the status of the run before it tries
> to reload it.
>
> 3) I saved the report as the recorder was still running (but
> kernelshark crashed). And then when I loaded the report (attached)
> it just executed it. The "import" should just pull it in and load
> the settings. This way, one could make updates to a default saved
> record.
>
> These probably should be fixed before ks1.0 is released.
>
Thanks Steven!
I agree that we have to get these problems fixed before ks1.0. Can we
have a quick Zoom now, because I am not sure I understand the sequence
of actions (in 2 and 3) that made it crashing.
Thanks!
Yordan
> Thanks!
>
> -- Steve
>
prev parent reply other threads:[~2019-07-08 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 9:19 [PATCH v3] kernel-shark: Define a CMAKE_BUILD_TYPE "Package" Yordan Karadzhov (VMware)
2019-07-08 13:26 ` Steven Rostedt
2019-07-08 14:02 ` Yordan Karadzhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30a439a4-fd66-cbed-5c6d-08fa2af22a82@vmware.com \
--to=ykaradzhov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).