linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: Some issues I found with KernelShark 1.0 prototype
Date: Wed, 26 Sep 2018 10:22:17 +0300	[thread overview]
Message-ID: <31d115c7-a846-9da8-7ccd-483b0475db1f@gmail.com> (raw)
In-Reply-To: <20180925123320.71d0d580@vmware.local.home>

Hi Steven,

On 25.09.2018 19:33, Steven Rostedt wrote:
> Hi Yordan,
> 
> While writing my presentation I found a few slight issues that we need
> to address.
> 
>   1. Need to show the task in the info window when hovering over the CPU
>      plot between events, but not idle 

OK, I will tray implementing this.

> 
>   2. Is there a way to do a quick zoom out. When I zoom in with a lot of
>      data, I find that it's quite slow to zoom back out to the original
>      screen.

Yes, this is trivial. We just have to find a way to make it intuitive.
Maybe adding another button?


>   3. We need a "File exists, do you want to overwrite" type dialog box
>      when saving a session over a file that already exists.

Hmm, I thought that it asks before overwriting. I will check this again.

> 
>   4. When restoring a session, the full path of the file being loaded
>      should be shown. I noticed this because I was loading a trace.dat
>      file from a different directory, and I wasn't sure which file it
>      found, as I have several trace.dat files.

The full path of the loaded file is shown as part of the name of the 
window. It will be "KernelShark(/some/path/somefile.dat)"

> 
>   5. I noticed a glitch when loading a session with both the A and B
>      markers are set here only one marker was shown in the list view.
>      I can put the session and trace.dat file someplace that you can
>      test this if you want.
> 

There is some regression in the import/export session code. I also 
noticed some problems there. Will do a careful look.

Thanks a lot for reporting all this issues!
Looking forward to see your talk.

cheers,
Yordan


> But so far it looks great! Tomorrow I'll be presenting my talk at 11am
> your time. It will hopefully be live streamed if they don't have the
> issues that they had at Embedded Recipes. I'll email the list the link
> when I have it.
> 
> -- Steve
> 

      reply	other threads:[~2018-09-26 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 16:33 Some issues I found with KernelShark 1.0 prototype Steven Rostedt
2018-09-26  7:22 ` Yordan Karadzhov (VMware) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31d115c7-a846-9da8-7ccd-483b0475db1f@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).