From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>, Tao Zhou <tao.zhou@linux.dev>
Cc: Ingo Molnar <mingo@redhat.com>, Tom Zanussi <zanussi@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>,
Clark Williams <williams@redhat.com>,
John Kacur <jkacur@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-rt-users@vger.kernel.org,
linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 08/20] rtla: Helper functions for rtla
Date: Tue, 26 Oct 2021 21:45:43 +0200 [thread overview]
Message-ID: <435460f4-7e69-dc39-109b-a6a777da69d7@kernel.org> (raw)
In-Reply-To: <20211026122614.017844da@gandalf.local.home>
On 10/26/21 18:26, Steven Rostedt wrote:
> On Wed, 27 Oct 2021 00:22:04 +0800
> Tao Zhou <tao.zhou@linux.dev> wrote:
>
>>> + do {
>>> + retval = read(in_fd, buffer, sizeof(buffer));
>>> + if (read <= 0)
>> check "retval" not read. Like:
>>
>> if (retval <= 0)
> OUCH! Good check.
>
> Daniel, did that not produce any warnings??
OUCH OUCH!
No warnings, no nothing.
The code actually "works" because errors are not common and the next if stops
the loop.
-- Daniel
> -- Steve
>
>
next prev parent reply other threads:[~2021-10-26 19:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 17:40 [PATCH V5 00/20] RTLA: An interface for osnoise/timerlat tracers Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 01/20] trace/osnoise: Do not follow tracing_cpumask Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 02/20] trace/osnoise: Improve comments about barrier need for NMI callbacks Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 03/20] trace/osnoise: Split workload start from the tracer start Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 04/20] trace/osnoise: Use start/stop_per_cpu_kthreads() on osnoise_cpus_write() Daniel Bristot de Oliveira
2021-10-26 1:08 ` Steven Rostedt
2021-10-26 8:23 ` Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 05/20] trace/osnoise: Support a list of trace_array *tr Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 06/20] trace/osnoise: Allow multiple instances of the same tracer Daniel Bristot de Oliveira
2021-10-26 2:08 ` Steven Rostedt
2021-10-26 8:38 ` Daniel Bristot de Oliveira
2021-10-26 13:02 ` Steven Rostedt
2021-10-25 17:40 ` [PATCH V5 07/20] rtla: Real-Time Linux Analysis tool Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 08/20] rtla: Helper functions for rtla Daniel Bristot de Oliveira
2021-10-26 16:22 ` Tao Zhou
2021-10-26 16:26 ` Steven Rostedt
2021-10-26 19:45 ` Daniel Bristot de Oliveira [this message]
2021-10-26 19:43 ` Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 09/20] rtla: Add osnoise tool Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 10/20] rtla/osnoise: Add osnoise top mode Daniel Bristot de Oliveira
2021-10-26 16:32 ` Tao Zhou
2021-10-26 19:50 ` Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 11/20] rtla/osnoise: Add the hist mode Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 12/20] rtla: Add timerlat tool and timelart top mode Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 13/20] rtla/timerlat: Add timerlat hist mode Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 14/20] rtla: Add Documentation Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 15/20] rtla: Add rtla osnoise man page Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 16/20] rtla: Add rtla osnoise top documentation Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 17/20] rtla: Add rtla osnoise hist documentation Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 18/20] rtla: Add rtla timerlat documentation Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 19/20] rtla: Add rtla timerlat top documentation Daniel Bristot de Oliveira
2021-10-25 17:40 ` [PATCH V5 20/20] rtla: Add rtla timerlat hist documentation Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435460f4-7e69-dc39-109b-a6a777da69d7@kernel.org \
--to=bristot@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tao.zhou@linux.dev \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).