Re: [PATCH] kernelshark: Set QApplication::desktopFileName

[Nicolas Fella <nicolas.fella@gmx.de>]

On 3/22/22 12:32, Yordan Karadzhov wrote:
>
>
> On 22.03.22 г. 0:53 ч., Nicolas Fella wrote:
>> This is needed for properly associating the window with the desktop
>> file.
>>
>> This is needed for e.g. showing the correct icon in desktop
>> environments.
>>
>> Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
>> ---
>>   src/kernelshark.cpp | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/kernelshark.cpp b/src/kernelshark.cpp
>> index 92bc1f1..c373f54 100644
>> --- a/src/kernelshark.cpp
>> +++ b/src/kernelshark.cpp
>> @@ -56,6 +56,7 @@ int main(int argc, char **argv)
>>       int c;
>>
>>       QApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
>> +    QApplication::setDesktopFileName("kernelshark");
>
> Hi Nicolas,
>
> Looking into the Qt documentation, it seems to me that the argument
> must be the desktop file name without the full path. And the name of
> the file is 'kernelshark.desktop'.

Hi,

the .desktop extension is implicit/not needed here. The documentation
says "the _base_ name of the desktop entry for this application"
(emphasis is mine).

Cheers

Nicolas

>
> Thanks!
> Yordan
>
>>       QApplication a(argc, argv);
>>
>>       KsMainWindow ks;
>> --
>> 2.35.1
>>