Re: [PATCH] kernel-shark: Separate trace-cmd and kernelshark documentations.

["Yordan Karadzhov (VMware)" <y.karadz@gmail.com>]

On 1.08.19 г. 16:25 ч., Steven Rostedt wrote:
> On Thu,  1 Aug 2019 15:19:55 +0300
> "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> 
>> KernelShark is going to be a stand alone package, separate from trace-cmd.
>> The code is already in its own directory, but HTML and man page documents
>> are still not separated.
>> All KernelShark related documentation (HTML and the man page) is moved
>> from Documentation/ to kernel-shark/doc/ directory.
>> New targets are added to trace-cmd Makefile:
>>   doc_gui - build KernelShrak documentation
>>   doc_gui_clean - clean KernelShrak documentation
>>   install_doc_gui - install KernelShrak documentation
>> The existing Makefile targets:
>>   doc, doc_clean, install_doc
>> are modified to work only with trace-cmd documentation.
>> The new Makefile targets must be used to build and install KernelShark docs.
>>
>> This change was requested by Bas van Dijk <v.dijk.bas@gmail.com>, to
>> simplify packaging trace-cmd and kernelshark for nixpkgs, as two
>> different packages.
>>
>> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
>> ---
> 
> 
>>   rename {Documentation => kernel-shark/doc}/HTML/images/kernelshark-logo.svg (100%)
> 
> When I first saw this, I questioned moving this out of Documentation.
> But thinking about it more, it does make sense.
> 
> But can I ask you to keep the "Documentation" name?
> 
> It just seems more professional, and also stays in line with the
> trace-cmd and Linux kernel "Documentation" directory name.


I agree. Let's rename kernel-shark/doc to kernel-shark/Documentation.

Thanks!
Yordan

> 
> Thanks!
> 
> -- Steve
>