* Re: [PATCH] Compile kernel-shark with -fPIC option [not found] <1556209669-2610-1-git-send-email-amikhak@wirelessfabric.com> @ 2019-04-25 16:34 ` Steven Rostedt 2019-05-08 1:38 ` Steven Rostedt 0 siblings, 1 reply; 3+ messages in thread From: Steven Rostedt @ 2019-04-25 16:34 UTC (permalink / raw) To: Alan Mikhak; +Cc: ykaradzhov, Linux Trace Devel Hi Alan, Thanks for the patch. FYI, it's best to also Cc linux-trace-devel@vger.kernel.org when sending patches. On Thu, 25 Apr 2019 09:27:49 -0700 Alan Mikhak <amikhak@wirelessfabric.com> wrote: > From: Alan Mikhak <amikhak@wirelessfabric.com> > > Resolve linker relocation error when linking libkshark.so.0.9.8 > with cmake on armv7l, aarch64, and some x86_64 platforms. > > Ubuntu 16.04 (xenial) on x86_64: > relocation R_X86_64_32 against `.rodata.str1.1' can not be used when > making a shared object; recompile with -fPIC > > Debian 9.8 (stretch) on x86_64: > relocation R_X86_64_TPOFF32 against `seq' can not be used when making > a shared object; recompile with -fPIC > > Signed-off-by: Alan Mikhak <amikhak@wirelessfabric.com> > --- > kernel-shark/CMakeLists.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel-shark/CMakeLists.txt b/kernel-shark/CMakeLists.txt > index 1aee858..ac17642 100644 > --- a/kernel-shark/CMakeLists.txt > +++ b/kernel-shark/CMakeLists.txt > @@ -32,8 +32,8 @@ endif (Qt5Widgets_FOUND) > set(LIBRARY_OUTPUT_PATH "${KS_DIR}/lib") > set(EXECUTABLE_OUTPUT_PATH "${KS_DIR}/bin") > > -set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -g -pthread") > -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -g -std=c++11 -pthread") > +set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -g -pthread -fPIC") > +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -g -std=c++11 -pthread -fPIC") Yordan, Can you take a look at this patch and add a Reviewed-by tag if you are good with it? -- Steve > > if(NOT _INSTALL_PREFIX) > set(_INSTALL_PREFIX "/usr/local") ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Compile kernel-shark with -fPIC option 2019-04-25 16:34 ` [PATCH] Compile kernel-shark with -fPIC option Steven Rostedt @ 2019-05-08 1:38 ` Steven Rostedt 2019-05-08 8:51 ` Yordan Karadzhov 0 siblings, 1 reply; 3+ messages in thread From: Steven Rostedt @ 2019-05-08 1:38 UTC (permalink / raw) To: Alan Mikhak; +Cc: ykaradzhov, Linux Trace Devel On Thu, 25 Apr 2019 12:34:36 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > Hi Alan, > > Thanks for the patch. FYI, it's best to also Cc > linux-trace-devel@vger.kernel.org when sending patches. > > On Thu, 25 Apr 2019 09:27:49 -0700 > Alan Mikhak <amikhak@wirelessfabric.com> wrote: > > > From: Alan Mikhak <amikhak@wirelessfabric.com> > > > > Resolve linker relocation error when linking libkshark.so.0.9.8 > > with cmake on armv7l, aarch64, and some x86_64 platforms. > > > > Ubuntu 16.04 (xenial) on x86_64: > > relocation R_X86_64_32 against `.rodata.str1.1' can not be used when > > making a shared object; recompile with -fPIC > > > > Debian 9.8 (stretch) on x86_64: > > relocation R_X86_64_TPOFF32 against `seq' can not be used when making > > a shared object; recompile with -fPIC > > > > Signed-off-by: Alan Mikhak <amikhak@wirelessfabric.com> > > --- > > kernel-shark/CMakeLists.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/kernel-shark/CMakeLists.txt b/kernel-shark/CMakeLists.txt > > index 1aee858..ac17642 100644 > > --- a/kernel-shark/CMakeLists.txt > > +++ b/kernel-shark/CMakeLists.txt > > @@ -32,8 +32,8 @@ endif (Qt5Widgets_FOUND) > > set(LIBRARY_OUTPUT_PATH "${KS_DIR}/lib") > > set(EXECUTABLE_OUTPUT_PATH "${KS_DIR}/bin") > > > > -set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -g -pthread") > > -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -g -std=c++11 -pthread") > > +set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -g -pthread -fPIC") > > +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -g -std=c++11 -pthread -fPIC") > > Yordan, > > Can you take a look at this patch and add a Reviewed-by tag if you are > good with it? This slipped through the cracks. Yordan, are you good with this? -- Steve > > > > > if(NOT _INSTALL_PREFIX) > > set(_INSTALL_PREFIX "/usr/local") ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Compile kernel-shark with -fPIC option 2019-05-08 1:38 ` Steven Rostedt @ 2019-05-08 8:51 ` Yordan Karadzhov 0 siblings, 0 replies; 3+ messages in thread From: Yordan Karadzhov @ 2019-05-08 8:51 UTC (permalink / raw) To: Steven Rostedt, Alan Mikhak; +Cc: Linux Trace Devel On 8.05.19 г. 4:38 ч., Steven Rostedt wrote: > On Thu, 25 Apr 2019 12:34:36 -0400 > Steven Rostedt <rostedt@goodmis.org> wrote: > >> Hi Alan, >> >> Thanks for the patch. FYI, it's best to also Cc >> linux-trace-devel@vger.kernel.org when sending patches. >> >> On Thu, 25 Apr 2019 09:27:49 -0700 >> Alan Mikhak <amikhak@wirelessfabric.com> wrote: >> >>> From: Alan Mikhak <amikhak@wirelessfabric.com> >>> >>> Resolve linker relocation error when linking libkshark.so.0.9.8 >>> with cmake on armv7l, aarch64, and some x86_64 platforms. >>> >>> Ubuntu 16.04 (xenial) on x86_64: >>> relocation R_X86_64_32 against `.rodata.str1.1' can not be used when >>> making a shared object; recompile with -fPIC >>> >>> Debian 9.8 (stretch) on x86_64: >>> relocation R_X86_64_TPOFF32 against `seq' can not be used when making >>> a shared object; recompile with -fPIC >>> >>> Signed-off-by: Alan Mikhak <amikhak@wirelessfabric.com> >>> --- >>> kernel-shark/CMakeLists.txt | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/kernel-shark/CMakeLists.txt b/kernel-shark/CMakeLists.txt >>> index 1aee858..ac17642 100644 >>> --- a/kernel-shark/CMakeLists.txt >>> +++ b/kernel-shark/CMakeLists.txt >>> @@ -32,8 +32,8 @@ endif (Qt5Widgets_FOUND) >>> set(LIBRARY_OUTPUT_PATH "${KS_DIR}/lib") >>> set(EXECUTABLE_OUTPUT_PATH "${KS_DIR}/bin") >>> >>> -set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -g -pthread") >>> -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -g -std=c++11 -pthread") >>> +set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -g -pthread -fPIC") >>> +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -g -std=c++11 -pthread -fPIC") >> >> Yordan, >> >> Can you take a look at this patch and add a Reviewed-by tag if you are >> good with it? > > This slipped through the cracks. Yordan, are you good with this? > I am sorry for the slow reaction! Reviewed-by: Yordan Karadzhov <ykaradzhov@vmware.com> Cheers, Yordan > -- Steve > >> >>> >>> if(NOT _INSTALL_PREFIX) >>> set(_INSTALL_PREFIX "/usr/local") > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-08 8:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1556209669-2610-1-git-send-email-amikhak@wirelessfabric.com>
2019-04-25 16:34 ` [PATCH] Compile kernel-shark with -fPIC option Steven Rostedt
2019-05-08 1:38 ` Steven Rostedt
2019-05-08 8:51 ` Yordan Karadzhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).