From: Slavomir Kaslev <slavomir.kaslev@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org, pauld@redhat.com,
ykaradzhov@vmware.com, jbacik@fb.com, tstoyanov@vmware.com
Subject: Re: [PATCH v3 1/2] trace-cmd: Optimize how pid filters are expressed
Date: Wed, 17 Apr 2019 16:44:11 +0300 [thread overview]
Message-ID: <53f5d46695a66aaf103a31817855629675f4938b.camel@gmail.com> (raw)
In-Reply-To: <20190416174810.50d8a88d@gandalf.local.home>
On Tue, 2019-04-16 at 17:48 -0400, Steven Rostedt wrote:
> On Tue, 16 Apr 2019 02:00:15 +0300
> Slavomir Kaslev <kaslevs@vmware.com> wrote:
>
> > static char *make_pid_filter(char *curr_filter, const char *field)
> > {
> > + int curr_len = 0, last_exclude = -1;
>
> Small nit. Usually when adding multiple variables on one line like
> this, the variables should be related. Because curr_len and
> last_exclude are not related, it is best to keep them separate.
Sent v4 addressing those and added a section about --no-filter to
trace-cmd record's man page.
Cheers,
-- Slavi
next prev parent reply other threads:[~2019-04-17 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 23:00 [PATCH v3 0/2] Optimize pid filters and add --no-filter option Slavomir Kaslev
2019-04-15 23:00 ` [PATCH v3 1/2] trace-cmd: Optimize how pid filters are expressed Slavomir Kaslev
2019-04-16 21:48 ` Steven Rostedt
2019-04-17 13:44 ` Slavomir Kaslev [this message]
2019-04-15 23:00 ` [PATCH v3 2/2] trace-cmd: Add --no-filter option to not filter recording processes Slavomir Kaslev
2019-04-16 21:49 ` Steven Rostedt
2019-04-16 13:22 ` [PATCH v3 0/2] Optimize pid filters and add --no-filter option Phil Auld
2019-04-16 21:39 ` Steven Rostedt
2019-04-17 0:29 ` Phil Auld
2019-04-17 12:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f5d46695a66aaf103a31817855629675f4938b.camel@gmail.com \
--to=slavomir.kaslev@gmail.com \
--cc=jbacik@fb.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=pauld@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tstoyanov@vmware.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).