From: Yordan Karadzhov <y.karadz@gmail.com>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] libtracefs: New API for getting synthetic event
Date: Thu, 13 Jan 2022 14:41:14 +0200 [thread overview]
Message-ID: <5891ee9c-ef5d-9f9e-c90a-2cdfe4f21cce@gmail.com> (raw)
In-Reply-To: <CAPpZLN7C7dBzzBuvtofz8zYh33utTzDC2x85MGPN2oGPvoksKA@mail.gmail.com>
On 13.01.22 г. 14:37 ч., Tzvetomir Stoyanov wrote:
> On Thu, Jan 13, 2022 at 12:26 PM Yordan Karadzhov <y.karadz@gmail.com> wrote:
>>
>>
>>
>> On 13.01.22 г. 7:01 ч., Tzvetomir Stoyanov wrote:
>>>> +struct tep_event pass:[*]*tracefs_synth_get_event*(struct tep_handle pass:[*]_tep_, struct tracefs_synth pass:[*]_synth_);
>>> The arguments of the other functions in this man page are not
>>> underlined, all should follow the same style. As in the other man
>>> pages of the library all arguments are underlined, this should be the
>>> default style.
>>> This could be addressed in a follow up patch - applying the same style
>>> of all tracefs man pages.
>>>
>>
>> So, do I have to change something on this particular line?
>
> This line is OK, I'll submit a patch to unify the other man pages. The
> arguments should be underlined.
>
OK, I will send v2, fixing the other problems you found in your review.
thanks,
Y.
>>
>> Thanks!
>> Yordan
>
>
>
next prev parent reply other threads:[~2022-01-13 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 16:36 [PATCH] libtracefs: New API for getting synthetic event Yordan Karadzhov (VMware)
2022-01-13 5:01 ` Tzvetomir Stoyanov
2022-01-13 10:26 ` Yordan Karadzhov
2022-01-13 12:37 ` Tzvetomir Stoyanov
2022-01-13 12:41 ` Yordan Karadzhov [this message]
2022-01-13 19:17 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5891ee9c-ef5d-9f9e-c90a-2cdfe4f21cce@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox