linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>,
	rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] KernelShark: Add guest's stream ID to the combobox item.
Date: Thu, 3 Sep 2020 16:53:55 +0300	[thread overview]
Message-ID: <5a3cc0b3-5301-22fd-a116-9800dc5ea146@gmail.com> (raw)
In-Reply-To: <20200902161118.46163-1-tz.stoyanov@gmail.com>



On 2.09.20 г. 19:11 ч., Tzvetomir Stoyanov (VMware) wrote:
> From: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
> 
> When a new stream is added to the list of guest streams in the ComboBox
> plugin, attach the stream ID to the entry as well. Later, when the
> stream is selected from the list, this ID is used to get information of
> the stream.
> 
> Signed-off-by: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
> ---
>   src/plugins/KVMCombo.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/plugins/KVMCombo.cpp b/src/plugins/KVMCombo.cpp
> index 4ca33d4..bc3c6b0 100644
> --- a/src/plugins/KVMCombo.cpp
> +++ b/src/plugins/KVMCombo.cpp
> @@ -269,7 +269,7 @@ void KsComboPlotDialog::update()
>   			continue;
>   
>   		streamName = KsUtils::streamDescription(kshark_ctx->stream[sd]);
> -		_guestStreamComboBox.addItem(streamName);
> +		_guestStreamComboBox.addItem(streamName, sd);
>   		color << colTable[sd];
>   		_guestStreamComboBox.setItemData(i, QBrush(color),
>   						    Qt::BackgroundRole);
> 

Thanks Ceco!
The patch is applied.

Yordan

      reply	other threads:[~2020-09-03 14:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02 16:11 [PATCH] KernelShark: Add guest's stream ID to the combobox item Tzvetomir Stoyanov (VMware)
2020-09-03 13:53 ` Yordan Karadzhov (VMware) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a3cc0b3-5301-22fd-a116-9800dc5ea146@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).