* [PATCH] tools/rtla: Fix command symlinks
@ 2022-07-16 13:47 Ben Hutchings
2022-07-20 12:32 ` Daniel Bristot de Oliveira
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2022-07-16 13:47 UTC (permalink / raw)
To: Daniel Bristot de Oliveira, Steven Rostedt, linux-trace-devel
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
"ln -s" stores the next argument directly as the symlink target, so
it needs to be a relative path. In this case, just "rtla".
Fixes: 0605bf009f18 ("rtla: Add osnoise tool")
Fixes: a828cd18bc4a ("rtla: Add timerlat tool and timelart top mode")
Signed-off-by: Ben Hutchings <benh@debian.org>
---
--- a/tools/tracing/rtla/Makefile
+++ b/tools/tracing/rtla/Makefile
@@ -108,9 +108,9 @@ install: doc_install
$(INSTALL) rtla -m 755 $(DESTDIR)$(BINDIR)
$(STRIP) $(DESTDIR)$(BINDIR)/rtla
@test ! -f $(DESTDIR)$(BINDIR)/osnoise || rm $(DESTDIR)$(BINDIR)/osnoise
- ln -s $(DESTDIR)$(BINDIR)/rtla $(DESTDIR)$(BINDIR)/osnoise
+ ln -s rtla $(DESTDIR)$(BINDIR)/osnoise
@test ! -f $(DESTDIR)$(BINDIR)/timerlat || rm $(DESTDIR)$(BINDIR)/timerlat
- ln -s $(DESTDIR)$(BINDIR)/rtla $(DESTDIR)$(BINDIR)/timerlat
+ ln -s rtla $(DESTDIR)$(BINDIR)/timerlat
.PHONY: clean tarball
clean: doc_clean
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/rtla: Fix command symlinks
2022-07-16 13:47 [PATCH] tools/rtla: Fix command symlinks Ben Hutchings
@ 2022-07-20 12:32 ` Daniel Bristot de Oliveira
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Bristot de Oliveira @ 2022-07-20 12:32 UTC (permalink / raw)
To: Ben Hutchings, Steven Rostedt, linux-trace-devel
On 7/16/22 15:47, Ben Hutchings wrote:
> "ln -s" stores the next argument directly as the symlink target, so
> it needs to be a relative path. In this case, just "rtla".
>
> Fixes: 0605bf009f18 ("rtla: Add osnoise tool")
> Fixes: a828cd18bc4a ("rtla: Add timerlat tool and timelart top mode")
> Signed-off-by: Ben Hutchings <benh@debian.org>
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Thanks!
-- Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-20 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-16 13:47 [PATCH] tools/rtla: Fix command symlinks Ben Hutchings
2022-07-20 12:32 ` Daniel Bristot de Oliveira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).