Re: [PATCH v2 2/3] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark

[Yordan Karadzhov <ykaradzhov@vmware.com>]

On 26.03.19 г. 22:51 ч., Steven Rostedt wrote:
> On Wed, 13 Mar 2019 17:22:19 +0200
> Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> 
>> @@ -12,10 +12,12 @@ message("\n project: Kernel Shark: (version: ${KS_VERSION_STRING})\n")
>>   
>>   set(KS_DIR ${CMAKE_SOURCE_DIR})
>>   
>> -# Make a directory to hold configuration files. To change this do:
>> -# cmake .. -DKS_CONF_DIR=/your/preferred/path
>> -set(KS_CONF_DIR "${KS_DIR}/.ksconf" CACHE STRING "Directory for configuration files.")
>> -file(MAKE_DIRECTORY ${KS_CONF_DIR})
>> +# Make a directory to hold cached configuration files. To change this do:
>> +# cmake .. -DKS_CACHE_DIR=/your/preferred/path
>> +set(KS_CACHE_DIR "$ENV{HOME}/.cache/kernelshark"
>> +    CACHE STRING "Directory for cached configuration files.")
>> +
>> +file(MAKE_DIRECTORY ${KS_CACHE_DIR})
>>   
> 
> This time I'm not confused (I tried it out).
> 
> The build process should *not* make the .cache/kernelshark directory.
> It should be made by the application, just like all other applications
> do.
> 

Yes, this makes sense. I will make the application creating the 
.cache/kernelshark directory if it doesn't exist.

But do I need to remove the creation of directory in the build process?

Thanks!
Yordan


> -- Steve
>