linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Tao Zhou <tao.zhou@linux.dev>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Marco Elver <elver@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Gabriele Paoloni <gpaoloni@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Clark Williams <williams@redhat.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH V9 03/16] rv/include: Add helper functions for deterministic automata
Date: Sun, 31 Jul 2022 18:02:47 +0200	[thread overview]
Message-ID: <7b3f7ec1-a479-f3ed-42b3-ddead0f9b427@kernel.org> (raw)
In-Reply-To: <YuacJsPya8PSE8qt@geo.homenetwork>

On 7/31/22 17:13, Tao Zhou wrote:
> On Fri, Jul 29, 2022 at 11:38:42AM +0200, Daniel Bristot de Oliveira wrote:
> 
> [...]
> 
>> +static inline type model_get_next_state_##name(enum states_##name curr_state,	\
>> +					       enum events_##name event)	\
>> +{										\
>> +	if ((curr_state < 0) || (curr_state >= state_max_##name))		\
>> +		return INVALID_STATE;						\
>> +										\
>> +	if ((event < 0) || (event >= event_max_##name))				\
>> +		return INVALID_STATE;						\
> 
> Should define the INVALID_EVENT corresponding to event invalid case.

no.

-- Daniel

  reply	other threads:[~2022-07-31 16:03 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29  9:38 [PATCH V9 00/16] The Runtime Verification (RV) interface Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 01/16] rv: Add " Daniel Bristot de Oliveira
2022-07-30 14:08   ` Tao Zhou
2022-07-30 17:01     ` Steven Rostedt
2022-07-30 22:05       ` Tao Zhou
2022-07-30 18:07     ` Daniel Bristot de Oliveira
2022-07-31 15:06       ` Tao Zhou
2022-07-31 15:56         ` Daniel Bristot de Oliveira
2022-07-31 16:48           ` Steven Rostedt
2022-07-31 16:47         ` Steven Rostedt
2022-07-31 17:01           ` Steven Rostedt
2022-07-31 17:49             ` Daniel Bristot de Oliveira
2022-07-31 17:53               ` Steven Rostedt
2022-07-29  9:38 ` [PATCH V9 02/16] rv: Add runtime reactors interface Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 03/16] rv/include: Add helper functions for deterministic automata Daniel Bristot de Oliveira
2022-07-31 15:13   ` Tao Zhou
2022-07-31 16:02     ` Daniel Bristot de Oliveira [this message]
2022-07-31 18:17       ` Tao Zhou
2022-07-29  9:38 ` [PATCH V9 04/16] rv/include: Add deterministic automata monitor definition via C macros Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 05/16] rv/include: Add instrumentation helper functions Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 06/16] Documentation/rv: Add a basic documentation Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 07/16] tools/rv: Add dot2c Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 08/16] Documentation/rv: Add deterministic automaton documentation Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 09/16] tools/rv: Add dot2k Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 10/16] Documentation/rv: Add deterministic automata monitor synthesis documentation Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 11/16] Documentation/rv: Add deterministic automata instrumentation documentation Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 12/16] rv/monitor: Add the wip monitor skeleton created by dot2k Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 13/16] rv/monitor: Add the wip monitor Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 14/16] rv/monitor: Add the wwnr monitor Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 15/16] rv/reactor: Add the printk reactor Daniel Bristot de Oliveira
2022-07-29  9:38 ` [PATCH V9 16/16] rv/reactor: Add the panic reactor Daniel Bristot de Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b3f7ec1-a479-f3ed-42b3-ddead0f9b427@kernel.org \
    --to=bristot@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=gpaoloni@redhat.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tao.zhou@linux.dev \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=williams@redhat.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).