[PATCH] libtracecmd: don't ignore LDFLAGS when linking the shared libs

[PATCH] libtracecmd: don't ignore LDFLAGS when linking the shared libs

[Jerome Marchand]

do_compile_shared_library should't ignore LDFLAGS. That makes it
difficult for packager to follow their distribution packaging
guidelines.

Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
---
 scripts/utils.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/utils.mk b/scripts/utils.mk
index 6865a746..53b2b074 100644
--- a/scripts/utils.mk
+++ b/scripts/utils.mk
@@ -72,7 +72,7 @@ do_build_static_lib =				\
 
 do_compile_shared_library =			\
 	($(print_shared_lib_compile)		\
-	$(CC) --shared $^ '-Wl,-soname,$(@F),-rpath=$$ORIGIN' -o $@ $(LIBS))
+	$(CC) --shared $^ '-Wl,-soname,$(@F),-rpath=$$ORIGIN' -o $@ $(LDFLAGS) $(LIBS))
 
 do_compile_plugin_obj =				\
 	($(print_plugin_obj_compile)		\
-- 
2.31.1

Re: [PATCH] libtracecmd: don't ignore LDFLAGS when linking the shared libs

[Steven Rostedt]

On Thu, 11 Nov 2021 19:03:18 +0100
"Jerome Marchand" <jmarchan@redhat.com> wrote:

> do_compile_shared_library should't ignore LDFLAGS. That makes it
> difficult for packager to follow their distribution packaging
> guidelines.
> 
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>

Thanks Jerome, I'll queue this up.

Looks like libtracefs may suffer from the same issue (and libtraceevent
looks fine).

  https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
  https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/

Did you want to submit a patch for libtracefs too?

-- Steve

> ---
>  scripts/utils.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/utils.mk b/scripts/utils.mk
> index 6865a746..53b2b074 100644
> --- a/scripts/utils.mk
> +++ b/scripts/utils.mk
> @@ -72,7 +72,7 @@ do_build_static_lib =				\
>  
>  do_compile_shared_library =			\
>  	($(print_shared_lib_compile)		\
> -	$(CC) --shared $^ '-Wl,-soname,$(@F),-rpath=$$ORIGIN' -o $@ $(LIBS))
> +	$(CC) --shared $^ '-Wl,-soname,$(@F),-rpath=$$ORIGIN' -o $@ $(LDFLAGS) $(LIBS))
>  
>  do_compile_plugin_obj =				\
>  	($(print_plugin_obj_compile)		\

Re: [PATCH] libtracecmd: don't ignore LDFLAGS when linking the shared libs

[Jerome Marchand]

On 11/11/2021 19:11, Steven Rostedt wrote:
> On Thu, 11 Nov 2021 19:03:18 +0100
> "Jerome Marchand" <jmarchan@redhat.com> wrote:
> 
>> do_compile_shared_library should't ignore LDFLAGS. That makes it
>> difficult for packager to follow their distribution packaging
>> guidelines.
>>
>> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
> 
> Thanks Jerome, I'll queue this up.
> 
> Looks like libtracefs may suffer from the same issue (and libtraceevent
> looks fine).
> 
>    https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
>    https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
> 
> Did you want to submit a patch for libtracefs too?

No, it wasn't my intention since I haven't noticed that, but it looks 
like pretty much the same patch would apply.

Jerome

> 
> -- Steve
> 
>> ---
>>   scripts/utils.mk | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/utils.mk b/scripts/utils.mk
>> index 6865a746..53b2b074 100644
>> --- a/scripts/utils.mk
>> +++ b/scripts/utils.mk
>> @@ -72,7 +72,7 @@ do_build_static_lib =				\
>>   
>>   do_compile_shared_library =			\
>>   	($(print_shared_lib_compile)		\
>> -	$(CC) --shared $^ '-Wl,-soname,$(@F),-rpath=$$ORIGIN' -o $@ $(LIBS))
>> +	$(CC) --shared $^ '-Wl,-soname,$(@F),-rpath=$$ORIGIN' -o $@ $(LDFLAGS) $(LIBS))
>>   
>>   do_compile_plugin_obj =				\
>>   	($(print_plugin_obj_compile)		\
>