From: Yordan Karadzhov <y.karadz@gmail.com>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] kernelshark: fix compiling error in LatencyPlot.cpp
Date: Sat, 15 Jun 2024 08:50:28 +0300 [thread overview]
Message-ID: <875a00be-1967-167d-e87d-67a53b82ecae@gmail.com> (raw)
In-Reply-To: <20240611153334.103780-1-jmarchan@redhat.com>
The patch is applied. Thanks!
Yordan
On 6/11/24 18:33, Jerome Marchand wrote:
> Include the <algorithm> header to use std::for_each.
>
> Fixes the following compilation error:
> kernel-shark/src/plugins/LatencyPlot.cpp: In function void draw_latency(kshark_cpp_argv*, int, int, int):
> kernel-shark/src/plugins/LatencyPlot.cpp:306:14: error: for_each is not a member of std
> 306 | std::for_each(range.first, range.second, lamPlotLat);
> | ^~~~~~~~
>
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
> ---
> src/plugins/LatencyPlot.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/plugins/LatencyPlot.cpp b/src/plugins/LatencyPlot.cpp
> index d412917..5e3393b 100644
> --- a/src/plugins/LatencyPlot.cpp
> +++ b/src/plugins/LatencyPlot.cpp
> @@ -15,6 +15,7 @@
> // C++
> #include <unordered_map>
> #include <iostream>
> +#include <algorithm>
>
> // KernelShark
> #include "plugins/latency_plot.h"
prev parent reply other threads:[~2024-06-15 5:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 15:33 [PATCH] kernelshark: fix compiling error in LatencyPlot.cpp Jerome Marchand
2024-06-15 5:50 ` Yordan Karadzhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875a00be-1967-167d-e87d-67a53b82ecae@gmail.com \
--to=y.karadz@gmail.com \
--cc=jmarchan@redhat.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).