* [PATCH] Documentation: rtla: Correct command line example
@ 2022-10-06 8:44 Pierre Gondois
2022-10-12 12:51 ` Daniel Bristot de Oliveira
2022-10-13 16:37 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Pierre Gondois @ 2022-10-06 8:44 UTC (permalink / raw)
To: linux-kernel
Cc: Pierre Gondois, Daniel Bristot de Oliveira, Steven Rostedt,
Jonathan Corbet, linux-trace-devel, linux-doc
The '-t/-T' parameters seem to have been swapped:
-t/--trace[=file]: save the stopped trace
to [file|timerlat_trace.txt]
-T/--thread us: stop trace if the thread latency
is higher than the argument in us
Swap them back.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
Documentation/tools/rtla/rtla-timerlat-top.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/tools/rtla/rtla-timerlat-top.rst b/Documentation/tools/rtla/rtla-timerlat-top.rst
index 1c321de1c171..7c4e4b109493 100644
--- a/Documentation/tools/rtla/rtla-timerlat-top.rst
+++ b/Documentation/tools/rtla/rtla-timerlat-top.rst
@@ -39,7 +39,7 @@ higher than *30 us*. It is also set to stop the session if a *Thread* timer
latency higher than *30 us* is hit. Finally, it is set to save the trace
buffer if the stop condition is hit::
- [root@alien ~]# rtla timerlat top -s 30 -t 30 -T
+ [root@alien ~]# rtla timerlat top -s 30 -T 30 -t
Timer Latency
0 00:00:59 | IRQ Timer Latency (us) | Thread Timer Latency (us)
CPU COUNT | cur min avg max | cur min avg max
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Documentation: rtla: Correct command line example
2022-10-06 8:44 [PATCH] Documentation: rtla: Correct command line example Pierre Gondois
@ 2022-10-12 12:51 ` Daniel Bristot de Oliveira
2022-10-13 16:37 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Bristot de Oliveira @ 2022-10-12 12:51 UTC (permalink / raw)
To: Pierre Gondois, linux-kernel
Cc: Steven Rostedt, Jonathan Corbet, linux-trace-devel, linux-doc
On 10/6/22 10:44, Pierre Gondois wrote:
> The '-t/-T' parameters seem to have been swapped:
> -t/--trace[=file]: save the stopped trace
> to [file|timerlat_trace.txt]
> -T/--thread us: stop trace if the thread latency
> is higher than the argument in us
I swapped them during the development, but it seems that I got the example
before swapping them :-).
> Swap them back.
>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Thanks!
-- Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: rtla: Correct command line example
2022-10-06 8:44 [PATCH] Documentation: rtla: Correct command line example Pierre Gondois
2022-10-12 12:51 ` Daniel Bristot de Oliveira
@ 2022-10-13 16:37 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2022-10-13 16:37 UTC (permalink / raw)
To: Pierre Gondois, linux-kernel
Cc: Pierre Gondois, Daniel Bristot de Oliveira, Steven Rostedt,
linux-trace-devel, linux-doc
Pierre Gondois <pierre.gondois@arm.com> writes:
> The '-t/-T' parameters seem to have been swapped:
> -t/--trace[=file]: save the stopped trace
> to [file|timerlat_trace.txt]
> -T/--thread us: stop trace if the thread latency
> is higher than the argument in us
>
> Swap them back.
>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> Documentation/tools/rtla/rtla-timerlat-top.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/tools/rtla/rtla-timerlat-top.rst b/Documentation/tools/rtla/rtla-timerlat-top.rst
> index 1c321de1c171..7c4e4b109493 100644
> --- a/Documentation/tools/rtla/rtla-timerlat-top.rst
> +++ b/Documentation/tools/rtla/rtla-timerlat-top.rst
> @@ -39,7 +39,7 @@ higher than *30 us*. It is also set to stop the session if a *Thread* timer
> latency higher than *30 us* is hit. Finally, it is set to save the trace
> buffer if the stop condition is hit::
>
> - [root@alien ~]# rtla timerlat top -s 30 -t 30 -T
> + [root@alien ~]# rtla timerlat top -s 30 -T 30 -t
> Timer Latency
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-13 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-06 8:44 [PATCH] Documentation: rtla: Correct command line example Pierre Gondois
2022-10-12 12:51 ` Daniel Bristot de Oliveira
2022-10-13 16:37 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).