From: Mike Frysinger <vapier@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
Ross Zwisler <zwisler@google.com>
Subject: Re: [PATCH] libtraceevent: Have 32 bit compile with -D_FILE_OFFSET_BITS=64
Date: Tue, 20 Dec 2022 16:29:49 -0500 [thread overview]
Message-ID: <CAAbOScks--ApY2b+4voM73PSx5dL1rLU7R3=8Bs66HDKN-6LMA@mail.gmail.com> (raw)
In-Reply-To: <20221220160002.1a34d937@gandalf.local.home>
On Tue, Dec 20, 2022 at 4:00 PM Steven Rostedt wrote:
> BTW, the only issue that will happen if stat fails, is that a feature will
> be disabled.
i am certainly by no means an expert in this codebase. from glancing
at it, the impact is that people won't be able to load any plugins
right ? that's where stat() & readdir() appear to be used (the dirent
returned by readdir has both ino_t & off_t in it).
-mike
next prev parent reply other threads:[~2022-12-20 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 22:34 [PATCH] libtraceevent: Have 32 bit compile with -D_FILE_OFFSET_BITS=64 Steven Rostedt
2022-12-20 19:36 ` Mike Frysinger
2022-12-20 21:00 ` Steven Rostedt
2022-12-20 21:29 ` Mike Frysinger [this message]
2022-12-20 21:35 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAbOScks--ApY2b+4voM73PSx5dL1rLU7R3=8Bs66HDKN-6LMA@mail.gmail.com' \
--to=vapier@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).