From: Joel Fernandes <joel@joelfernandes.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
rostedt@google.com, Vineeth Pillai <vineethrp@google.com>
Subject: Re: [PATCH] trace-cmd: Try alternate path for message cache
Date: Mon, 4 Apr 2022 13:20:00 -0400 [thread overview]
Message-ID: <CAEXW_YQnJ+USoaqYW7oHAt6aFi3VJfVz3bV5=XRL8GqCGUCiqQ@mail.gmail.com> (raw)
In-Reply-To: <20220404114744.283d4746@gandalf.local.home>
On Mon, Apr 4, 2022 at 11:47 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Mon, 4 Apr 2022 11:41:58 -0400
> Joel Fernandes <joel@joelfernandes.org> wrote:
>
> > > Agreed, so should I send a patch next to do memfd unless
> > > not-compressed? Is there an easy way to do not-compressed?
> >
> > Sorry I meant "is there an easy way to detect, in this code path, that
> > we are running in not compressed mode" ? I guess I could just check
> > the argv but I haven't looked closely yet.
>
> From that function not yet. We could add a flag.
>
> I think we could just take this patch and then I could add a way to put
> back the mktemp in compression = none mode.
>
> I rather have it broken up into multiple patches anyway.
That sounds good to me, thanks.
- Joel
prev parent reply other threads:[~2022-04-04 21:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 19:18 [PATCH] trace-cmd: Try alternate path for message cache Joel Fernandes
2022-04-01 19:37 ` Steven Rostedt
[not found] ` <CAEXW_YQxPgaKOMhDy8kVdaT9esvY8ctP1Mfw3RZXwkJkTYhh0w@mail.gmail.com>
2022-04-01 23:06 ` Steven Rostedt
2022-04-03 14:56 ` Joel Fernandes
2022-04-03 15:24 ` Joel Fernandes
2022-04-03 17:35 ` Steven Rostedt
2022-04-04 4:41 ` Tzvetomir Stoyanov
2022-04-04 5:02 ` Tzvetomir Stoyanov
2022-04-04 13:21 ` Joel Fernandes
2022-04-04 13:48 ` Tzvetomir Stoyanov
2022-04-04 14:11 ` Joel Fernandes
2022-04-04 14:35 ` Steven Rostedt
2022-04-04 14:48 ` Tzvetomir Stoyanov
2022-04-04 15:04 ` Steven Rostedt
2022-04-04 15:15 ` Tzvetomir Stoyanov
2022-04-04 15:27 ` Steven Rostedt
2022-04-04 15:32 ` Steven Rostedt
2022-04-04 15:40 ` Joel Fernandes
2022-04-04 15:41 ` Joel Fernandes
2022-04-04 15:47 ` Steven Rostedt
2022-04-04 17:20 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEXW_YQnJ+USoaqYW7oHAt6aFi3VJfVz3bV5=XRL8GqCGUCiqQ@mail.gmail.com' \
--to=joel@joelfernandes.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=rostedt@google.com \
--cc=tz.stoyanov@gmail.com \
--cc=vineethrp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).