From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6BC52D61D; Wed, 25 Oct 2023 05:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01F1E12F; Tue, 24 Oct 2023 22:51:54 -0700 (PDT) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-27d0e3d823fso3670181a91.1; Tue, 24 Oct 2023 22:51:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698213113; x=1698817913; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2TMBfJBS6+PFjOoTjREUjGF4g9nD1G3ML89T7sHAIHE=; b=II2AkRLF6IPNL205+OTGUatUsEU3SWGKh68OXC4qkEjkHvv7/v6H3vwlLPjc8GgMdC N2qkBfEF82oYLnuVIuMoLNduH0n6Rr47LzNvOMi0Td3E0+tbHasPHdgCg2i/R3mxA9D+ XFGjvLD0qpR7oQCbc0HsZ0SsbCRlCjJ0eA5YfYUNNvB2W1shJ9bp0bAxzZufjsajFepN 5WGyW7LCdCoIfNNkdfALHkIrNBD+GUW+aeyYbyoHy0nJ8CnXPKeXUrVkwAvX/fMhXpt4 yhimHvBMxQeZDUycJeC22P4WTpAP6euCZujB6D3Z5hLZ3AxBltjeOtSTX+fxt+uNAzRb 4xcw== X-Gm-Message-State: AOJu0Yy4OVnmG1wOX1fmaWfryP4i+MNWYVHJnomzOw1T1MQYVd5I1ZMB zak7GpKpqMam8geZqhrOsPIAcg2ItnrEXjUrMks= X-Google-Smtp-Source: AGHT+IHs6VkUGZcdZf7cWbqnymCoL3HDLsrq7a6rHvnt2eg1riPr61FqkJKAeE2+gtViW6QDTWgTrhrfzcetKAkILH4= X-Received: by 2002:a17:90b:3784:b0:27d:8fbd:be95 with SMTP id mz4-20020a17090b378400b0027d8fbdbe95mr11992237pjb.28.1698213113310; Tue, 24 Oct 2023 22:51:53 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-trace-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231012035111.676789-1-namhyung@kernel.org> <87pm15vw5r.fsf@linux.intel.com> In-Reply-To: From: Namhyung Kim Date: Tue, 24 Oct 2023 22:51:41 -0700 Message-ID: Subject: Re: [RFC 00/48] perf tools: Introduce data type profiling (v1) To: Andi Kleen Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Peter Zijlstra , Ian Rogers , Adrian Hunter , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org, Linus Torvalds , Stephane Eranian , Masami Hiramatsu , linux-toolchains@vger.kernel.org, linux-trace-devel@vger.kernel.org, Ben Woodard , Joe Mario , Kees Cook , David Blaikie , Xu Liu , Kan Liang , Ravi Bangoria Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 24, 2023 at 7:09=E2=80=AFPM Andi Kleen wro= te: > > > > > > > > > The main difference seems to be that mine was more for perf script > > > (e.g. i supported PT decoding), while you are more focused on samplin= g. > > > I relied on the kprobes/uprobes engine, which unfortunately was alway= s > > > quite slow and had many limitations. > > > > Right, I think dealing with regular samples would be more useful. > > My code supported samples too, but only through perf script, not report. > > See > > https://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git/commit/= ?h=3Dperf/var-resolve-7&id=3D4775664750a6296acb732b7adfa224c6a06a126f > > for an example. > > My take was that i wasn't sure that perf report is the right interface > to visualize the variables changing -- to be really usable you probably > need some plots and likely something like an UI. I see. Your concern is to see how variables are changing. But it seems you only displayed constant values. > > For you I think you focus more on the types than the individual > variables? That's a slightly different approach. Right, you can see which fields in a struct are accessed mostly and probably change the layout for better result. > > But then my engine had a lot of limitations, i suppose redoing that on > top of yours would give better results. Sounds good, thanks. Namhyung