From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
linux-trace-devel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
torvalds@linux-foundation.org, eranian@google.com
Subject: Re: [PATCH] perf build: Lower the priority of tools/lib includes
Date: Thu, 6 Jan 2022 12:24:18 -0800 [thread overview]
Message-ID: <CAP-5=fWNfB6g0Bk2zPH3yYuvcDQG7TGQ7DBsnkTc3pZF0jKoHA@mail.gmail.com> (raw)
In-Reply-To: <YddDcqxtDrPDSAVi@kernel.org>
On Thu, Jan 6, 2022 at 11:31 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Thu, Jan 06, 2022 at 04:28:58PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Jan 05, 2022 at 11:26:27PM -0800, Ian Rogers escreveu:
> > > tools/lib has a 1.1.0 copy of libtraceevent. If a newer system
> > > version is installed then its headers will go in /usr/include. As -I has
> > > priority over system headers the 1.1.0 version gets used in preference
> > > to the system one, which isn't what is wanted. To make the behavior
> > > match expectations use -idirafter so that any system headers have priority
> > > over the tools/lib version.
> > >
> > > Fixes: 08efcb4a638d ("libtraceevent: Increase libtraceevent logging when verbose")
> >
> > Hi,
> >
> > You forgot to add your Signed-off-by:, I'm adding it as you
> > usually provide it, ok?
>
> Also adding:
>
> Reported-by: Jiri Slaby <jirislaby@kernel.org>
>
> - Arnaldo
Thanks Arnaldo! Both good with me.
Ian
prev parent reply other threads:[~2022-01-06 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 7:26 [PATCH] perf build: Lower the priority of tools/lib includes Ian Rogers
2022-01-06 19:28 ` Arnaldo Carvalho de Melo
2022-01-06 19:30 ` Arnaldo Carvalho de Melo
2022-01-06 20:24 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fWNfB6g0Bk2zPH3yYuvcDQG7TGQ7DBsnkTc3pZF0jKoHA@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=jirislaby@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).