From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65224C433EF for ; Thu, 6 Jan 2022 20:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243689AbiAFUYc (ORCPT ); Thu, 6 Jan 2022 15:24:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243675AbiAFUYc (ORCPT ); Thu, 6 Jan 2022 15:24:32 -0500 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F58CC061201 for ; Thu, 6 Jan 2022 12:24:32 -0800 (PST) Received: by mail-il1-x12e.google.com with SMTP id j15so1911909ilq.4 for ; Thu, 06 Jan 2022 12:24:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1hwwvjlhtkCgnYzKELSHOhx4GC796dq3UFrZuDKUjZw=; b=pjeWTfqAAFn0D70nVe2H8jxZ56DPQQM86g1itSPNeUWz0Df2BWfBY2oSYu3YeKIbpf feXVe/PqKsxq+OmDKcwNK5HNjhEgvGGDSpQD8UKTVmvvBE9gFTvufl0oFWxHiN94cZ1E NHxtLrx3cyPsG4Re3rh5WX0osECP0cWJTpyC1DOdxUEbCueEoJG0zgPta22rWR8+bHwo nCthVCGSANxLMbHt6sTLddyqzYrkW8UrZWiPk+NNFFu+W1AmM50LOqk+SpAoZt8gn/2H xHaTQeju4IED99/3Jel58xaJn32WAeCrGthgnUc2Pd6BjhYWOenTFQ5L5Ce4dSgyiNRY rf3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1hwwvjlhtkCgnYzKELSHOhx4GC796dq3UFrZuDKUjZw=; b=uJAx/F1LYiHywp5HPmwSTgRnsL4T7J28x/HZyXJFpn7iUUY4+gWXtFs+nqFb/3Myjl FOx6H12n8uNiorqfcQNBAyAy4I2dv8/T1suHXPxVALx44EuaBoC8VtyUAzNhtM0AWrmW oMTZn0z3TF9T2QhEK1J8ygGx7lzrI+vvCCozMVfUjc0o4OdnYucpksBrrenxNSVCz8F+ 5vahKpCOvHkSVIzYOOcvUDjDD0PXbK3DzxJj2OmGtZ2tbR0W+8fPIWvyEQb80k9NIIhM 4CHqIPh2Gxe8Kd0bKXNrL2rO7MxIrYMuQKrRvoqHqP870rupPrNW571b7hWnplT+mnm/ EqYg== X-Gm-Message-State: AOAM531+PAopvIeSIp8/in6T8tn6azVtZwtoLC36WXDjTlTUNdTmSZp5 HmpUIbwJCKqdxlSst61CTM8sXOrTWK46uQqH6eyapA== X-Google-Smtp-Source: ABdhPJyQRHDqkZiMGNUXLizaclzFo6BOctys0w1THIbnIioQgwHfzgOf6Sh8VTpnDMkncqh8Z3v4x/MxVtKxkvvwFxs= X-Received: by 2002:a05:6e02:170c:: with SMTP id u12mr28684525ill.53.1641500671458; Thu, 06 Jan 2022 12:24:31 -0800 (PST) MIME-Version: 1.0 References: <20220106072627.476524-1-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Thu, 6 Jan 2022 12:24:18 -0800 Message-ID: Subject: Re: [PATCH] perf build: Lower the priority of tools/lib includes To: Arnaldo Carvalho de Melo Cc: Jiri Slaby , linux-trace-devel@vger.kernel.org, Steven Rostedt , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Tzvetomir Stoyanov , torvalds@linux-foundation.org, eranian@google.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, Jan 6, 2022 at 11:31 AM Arnaldo Carvalho de Melo wrote: > > Em Thu, Jan 06, 2022 at 04:28:58PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Jan 05, 2022 at 11:26:27PM -0800, Ian Rogers escreveu: > > > tools/lib has a 1.1.0 copy of libtraceevent. If a newer system > > > version is installed then its headers will go in /usr/include. As -I has > > > priority over system headers the 1.1.0 version gets used in preference > > > to the system one, which isn't what is wanted. To make the behavior > > > match expectations use -idirafter so that any system headers have priority > > > over the tools/lib version. > > > > > > Fixes: 08efcb4a638d ("libtraceevent: Increase libtraceevent logging when verbose") > > > > Hi, > > > > You forgot to add your Signed-off-by:, I'm adding it as you > > usually provide it, ok? > > Also adding: > > Reported-by: Jiri Slaby > > - Arnaldo Thanks Arnaldo! Both good with me. Ian