[PATCH] trace-cmd: Let subcommand "convert" automatically if possible.

[PATCH] trace-cmd: Let subcommand "convert" automatically if possible.

[Sebastian Andrzej Siewior]

Let the convert subcommand compress automatically if the file format
allows it and the user did not specify it.
This already the case the record command.

Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc
---
 Documentation/trace-cmd/trace-cmd-convert.1.txt | 3 ++-
 tracecmd/trace-convert.c                        | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/trace-cmd/trace-cmd-convert.1.txt b/Documentation/trace-cmd/trace-cmd-convert.1.txt
index 7c13cf3dcd625..21f580d6e1b6c 100644
--- a/Documentation/trace-cmd/trace-cmd-convert.1.txt
+++ b/Documentation/trace-cmd/trace-cmd-convert.1.txt
@@ -13,7 +13,8 @@ DESCRIPTION
 -----------
 The trace-cmd(1) convert command converts trace file. It reads the input file and copies the data
 into an output file. The output file may be in different format, depending on the command line
-arguments.
+arguments. The default output is in version 7 and compressed (if
+compiled with compression support).
 
 OPTIONS
 -------
diff --git a/tracecmd/trace-convert.c b/tracecmd/trace-convert.c
index 88935dc7b0a4c..e72a352685f42 100644
--- a/tracecmd/trace-convert.c
+++ b/tracecmd/trace-convert.c
@@ -104,6 +104,8 @@ void trace_convert(int argc, char **argv)
 		input_file = DEFAULT_INPUT_FILE;
 	if (!output_file)
 		usage(argv);
+	if (file_version >= FILE_VERSION_COMPRESSION && !compression)
+		compression = "any";
 
 	convert_file(input_file, output_file, file_version, compression);
 }
-- 
2.38.1

Re: [PATCH] trace-cmd: Let subcommand "convert" automatically if possible.

[Steven Rostedt]

On Sat, 10 Dec 2022 21:36:58 +0100
Sebastian Andrzej Siewior <sebastian@breakpoint.cc> wrote:

> Let the convert subcommand compress automatically if the file format
> allows it and the user did not specify it.
> This already the case the record command.
> 
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc

Oops, broken email, I'll fix.

Applied, thanks Sebastian!

-- Steve