From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17FEDC433F5 for ; Wed, 22 Sep 2021 21:10:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F26E7611C9 for ; Wed, 22 Sep 2021 21:10:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237930AbhIVVML (ORCPT ); Wed, 22 Sep 2021 17:12:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44502 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237927AbhIVVMK (ORCPT ); Wed, 22 Sep 2021 17:12:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632345040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QSaDDb+UPCl85zWqGodzp//Rjjy1AQfZIg0iKTqryTc=; b=RVwXfEGRUJK97+d5JxQEz2QUUl48sZfXdoRnhv5bX4s1WdKNXGYHJ9sA8RKw9AfVFShNIf cpuNRZONH3ayrmtVvLVq8IHHnHvIeRCEpe+VNQWfv7Z0J0eDvx95ytDprSQB/T0GYPEqPL qavfeZFDGkCa9179teio1UGgctgYKmc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-Nk6k8YKePZGn-BvWZtw_gg-1; Wed, 22 Sep 2021 17:10:38 -0400 X-MC-Unique: Nk6k8YKePZGn-BvWZtw_gg-1 Received: by mail-wr1-f72.google.com with SMTP id l9-20020adfc789000000b00160111fd4e8so3303792wrg.17 for ; Wed, 22 Sep 2021 14:10:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QSaDDb+UPCl85zWqGodzp//Rjjy1AQfZIg0iKTqryTc=; b=sGaOZFvq9+LachbjCoIoAfSorC17/qAde/vkh70l+yTLaxptkI7EiExgrKGDk+1H55 l9JTAGm+Ono/5Bj3evabPwLUVss8aCHbs9dOQIBpXGQhwdSQnWFsGEPrMZcvg2T6dPpe OlFwEmJevk1FV59Hefpjt8eh3aMDQRRSFBC5XzfxbHqAlMLczFqxJmoCK5lK3Izqnfwd nINXORIaCPoZLoIX2Ts9QbCP0DSmkA0RrSD1nyiU1zzPJTXrhS4Ui18a0wAvM2+7JkBm Z5P9XeIY38OcbEClgu4XTwlVLmAn1HqzhjfeppLuLZesY/+jWPLjbOi59Lj+3QUkDyxJ 6y5A== X-Gm-Message-State: AOAM530VnRP1lrJn4yGxtm3Hv6Mum4ycMaX2EM7WHdI7hcPbdl0M0FDC kwNWJSZ747iukS3s6KiN3qEf2CueE54HVlpyoyYYW9LYn7CKJmxvxcjgbLFug3LfHMU/rj1+M3R Q+OJG27oQBbYn7TbIbmc63nk6uRiWbd0= X-Received: by 2002:a5d:4cc6:: with SMTP id c6mr1205699wrt.108.1632345037785; Wed, 22 Sep 2021 14:10:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5T0pxBW9oWQ/llmaNM/LDVZnierNxbbZ52SgI25fsINV0QQ/74eaFTFihjih1WuagzrDGBg== X-Received: by 2002:a5d:4cc6:: with SMTP id c6mr1205678wrt.108.1632345037650; Wed, 22 Sep 2021 14:10:37 -0700 (PDT) Received: from krava ([83.240.63.48]) by smtp.gmail.com with ESMTPSA id h1sm3006175wmb.7.2021.09.22.14.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Sep 2021 14:10:37 -0700 (PDT) Date: Wed, 22 Sep 2021 23:10:35 +0200 From: Jiri Olsa To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, Tzvetomir Stoyanov , Steven Rostedt , eranian@google.com Subject: Re: [PATCH v2 1/4] perf: Enable libtracefs dynamic linking Message-ID: References: <20210921204839.236840-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210921204839.236840-1-irogers@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Tue, Sep 21, 2021 at 01:48:36PM -0700, Ian Rogers wrote: > Currently libtracefs isn't used by perf, but there are potential > improvements by using it as identified Steven Rostedt's e-mail: > https://lore.kernel.org/lkml/20210610154759.1ef958f0@oasis.local.home/ > > This change is modelled on the dynamic libtraceevent patch by Michael > Petlan: > https://lore.kernel.org/linux-perf-users/20210428092023.4009-1-mpetlan@redhat.com/ > > Signed-off-by: Ian Rogers > --- > tools/build/Makefile.feature | 1 + > tools/build/feature/Makefile | 4 ++++ > tools/perf/Makefile.config | 9 +++++++++ > tools/perf/Makefile.perf | 2 ++ > 4 files changed, 16 insertions(+) > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > index 3dd2f68366f9..45a9a59828c3 100644 > --- a/tools/build/Makefile.feature > +++ b/tools/build/Makefile.feature > @@ -52,6 +52,7 @@ FEATURE_TESTS_BASIC := \ > libslang \ > libslang-include-subdir \ > libtraceevent \ > + libtracefs \ > libcrypto \ > libunwind \ > pthread-attr-setaffinity-np \ > diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile > index eff55d287db1..d024b5204ba0 100644 > --- a/tools/build/feature/Makefile > +++ b/tools/build/feature/Makefile > @@ -36,6 +36,7 @@ FILES= \ > test-libslang.bin \ > test-libslang-include-subdir.bin \ > test-libtraceevent.bin \ > + test-libtracefs.bin \ > test-libcrypto.bin \ > test-libunwind.bin \ > test-libunwind-debug-frame.bin \ > @@ -199,6 +200,9 @@ $(OUTPUT)test-libslang-include-subdir.bin: > $(OUTPUT)test-libtraceevent.bin: > $(BUILD) -ltraceevent > > +$(OUTPUT)test-libtracefs.bin: > + $(BUILD) -ltracefs hum, looks like you forgot to git add test-libtracefs.c? jirka > + > $(OUTPUT)test-libcrypto.bin: > $(BUILD) -lcrypto > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > index 446180401e26..00ec900ddbca 100644 > --- a/tools/perf/Makefile.config > +++ b/tools/perf/Makefile.config > @@ -1098,6 +1098,15 @@ ifdef LIBTRACEEVENT_DYNAMIC > endif > endif > > +ifdef LIBTRACEFS_DYNAMIC > + $(call feature_check,libtracefs) > + ifeq ($(feature-libtracefs), 1) > + EXTLIBS += -ltracefs > + else > + dummy := $(error Error: No libtracefs devel library found, please install libtracefs-dev); > + endif > +endif > + > # Among the variables below, these: > # perfexecdir > # perf_include_dir > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index e04313c4d840..7df13e74450c 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -130,6 +130,8 @@ include ../scripts/utilities.mak > # > # Define LIBTRACEEVENT_DYNAMIC to enable libtraceevent dynamic linking > # > +# Define LIBTRACEFS_DYNAMIC to enable libtracefs dynamic linking > +# > > # As per kernel Makefile, avoid funny character set dependencies > unexport LC_ALL > -- > 2.33.0.464.g1972c5931b-goog >