From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>,
linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 3/5] trace-cmd: Use errno from zlib, if available
Date: Thu, 3 Mar 2022 08:09:17 +0100 [thread overview]
Message-ID: <YiBpnYaudLpde0dF@breakpoint.cc> (raw)
In-Reply-To: <20220302105230.179ad64a@gandalf.local.home>
On 2022-03-02 10:52:30 [-0500], Steven Rostedt wrote:
> On Wed, 2 Mar 2022 08:15:30 +0100
> Sebastian Andrzej Siewior <sebastian@breakpoint.cc> wrote:
>
> > I was thinking about returning the error for compress/decompress via the
> > return value and not touching errno at all.
>
> I know you hate the use of ERRNO in libraries and tooling, but we've decided
> to go that way for all of trace-cmd and the libraries (libtraceevent and
> libtracefs). This is just being consistent with all the other callers, and
> to do it differently will create an inconsistency in the API.
Ah okay then. In that case, the zstd interface does not set errno in the
compress or decompress callback. This might need an update to be
consistent. Otherwise the return value is < 0 and errno might still be
0.
> -- Steve
Sebastian
next prev parent reply other threads:[~2022-03-03 7:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 4:51 [PATCH 0/5] trace-cmd: Improvements in compression logic Tzvetomir Stoyanov (VMware)
2022-03-02 4:51 ` [PATCH 1/5] trace-cmd: Use a structure to describe a compression protocol Tzvetomir Stoyanov (VMware)
2022-03-02 7:03 ` Sebastian Andrzej Siewior
2022-03-02 4:51 ` [PATCH 2/5] trace-cmd: Make internal compression hooks more generic Tzvetomir Stoyanov (VMware)
2022-03-02 7:08 ` Sebastian Andrzej Siewior
2022-03-02 4:51 ` [PATCH 3/5] trace-cmd: Use errno from zlib, if available Tzvetomir Stoyanov (VMware)
2022-03-02 7:15 ` Sebastian Andrzej Siewior
2022-03-02 15:52 ` Steven Rostedt
2022-03-03 7:09 ` Sebastian Andrzej Siewior [this message]
2022-03-02 4:51 ` [PATCH 4/5] trace-cmd: Add context to compression hooks Tzvetomir Stoyanov (VMware)
2022-03-02 7:13 ` Sebastian Andrzej Siewior
2022-03-03 1:10 ` Steven Rostedt
2022-03-03 16:33 ` Tzvetomir Stoyanov
2022-03-02 4:51 ` [PATCH 5/5] trace-cmd: Use context hooks in zstd Tzvetomir Stoyanov (VMware)
2022-03-02 7:13 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiBpnYaudLpde0dF@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).