From: Ross Zwisler <zwisler@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] libtraceevent: Fix uninitialized variable in eval_num_arg()
Date: Fri, 23 Sep 2022 14:59:59 -0600 [thread overview]
Message-ID: <Yy4eT5SdhjxEat4L@google.com> (raw)
In-Reply-To: <20220923123014.489e0e39@gandalf.local.home>
On Fri, Sep 23, 2022 at 12:30:14PM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> It appears that my compiler version did not notice that "field_size"
> passed to check_data_offset_size() in the TEP_PRINT_DYNAMIC_ARRAY case was
> not initialized. But other compilers do.
>
> Since this case we just want to make sure the offset is not passed the end
> of the event data, we can simply pass in zero.
>
> Fixes: efd32896dd5db ("libtraceevent: Add warnings if fields are outside the event")
> Reported-by: Ross Zwisler <zwisler@google.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Reviewed-by: Ross Zwisler <zwisler@google.com>
prev parent reply other threads:[~2022-09-23 21:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 16:30 [PATCH] libtraceevent: Fix uninitialized variable in eval_num_arg() Steven Rostedt
2022-09-23 20:59 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy4eT5SdhjxEat4L@google.com \
--to=zwisler@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).