From: Marcelo Tosatti <mtosatti@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH] trace-cmd: fix --poll trace recording
Date: Mon, 29 Jan 2024 17:42:18 -0300 [thread overview]
Message-ID: <ZbgNqiyocHf/FEQw@tpad> (raw)
When using --poll, move_data() returns -1 and errno is set to EAGAIN.
This causes the record threads to stop recording.
Fix it by returning to the read loop in case EAGAIN, if --poll
is specified.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/lib/trace-cmd/trace-recorder.c b/lib/trace-cmd/trace-recorder.c
index 70ce52e..0633edf 100644
--- a/lib/trace-cmd/trace-recorder.c
+++ b/lib/trace-cmd/trace-recorder.c
@@ -421,6 +421,9 @@ int tracecmd_start_recording(struct tracecmd_recorder *recorder, unsigned long s
if (ret < 0) {
if (errno == EINTR)
continue;
+ if ((recorder->flags & TRACECMD_RECORD_POLL) &&
+ errno == EAGAIN)
+ continue;
return ret;
}
read += ret;
reply other threads:[~2024-01-29 20:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbgNqiyocHf/FEQw@tpad \
--to=mtosatti@redhat.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).