linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Daniel Bristot de Oliveira <bristot@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-trace-devel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rv: Fix addition on an uninitialized variable 'run'
Date: Mon, 24 Apr 2023 10:45:41 +0100	[thread overview]
Message-ID: <a9396dbe-08aa-620c-cb08-7ea9943e1561@gmail.com> (raw)
In-Reply-To: <20230424094446.105133-1-colin.i.king@gmail.com>

On 24/04/2023 10:44, Colin Ian King wrote:
> The variable run is not initialized however it is being accumulated
> by the return value from the call to ikm_run_monitor.  Fix this by
> initializing run to zero at the start of the function.
> 
> Fixes: 4bc4b131d44c ("rv: Add rv tool")
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>   tools/verification/rv/src/rv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/verification/rv/src/rv.c b/tools/verification/rv/src/rv.c
> index e601cd9c411e..1ddb85532816 100644
> --- a/tools/verification/rv/src/rv.c
> +++ b/tools/verification/rv/src/rv.c
> @@ -74,7 +74,7 @@ static void rv_list(int argc, char **argv)
>   static void rv_mon(int argc, char **argv)
>   {
>   	char *monitor_name;
> -	int i, run;
> +	int i, run = 0;
>   
>   	static const char *const usage[] = {
>   		"",

Oops, I forgot the V2, will re-send as a V3. My bad.

  reply	other threads:[~2023-04-24  9:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24  9:44 [PATCH] rv: Fix addition on an uninitialized variable 'run' Colin Ian King
2023-04-24  9:45 ` Colin King (gmail) [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-04-17 10:39 Colin Ian King
2023-04-24  9:09 ` Daniel Bristot de Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9396dbe-08aa-620c-cb08-7ea9943e1561@gmail.com \
    --to=colin.i.king@gmail.com \
    --cc=bristot@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).