Re: [PATCH v2 2/2] trace-filter: Change the hashing function used when filtering

["Yordan Karadzhov (VMware)" <y.karadz@gmail.com>]

On 20.06.2018 01:54, Steven Rostedt wrote:
> On Tue, 19 Jun 2018 16:22:59 +0300
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> 
>> The hashing function used in trace-filter-hash is changed.
>> The new hashing functions is based on the Donald E. Knuth's
>> Multiplicative hashing, suggested in his book "The Art of
>> Computer Programming". This improves the performance, but
>> also removes the restrictions resulting  from using the
>> Paul Hsieh's super fast hash, published under the terms of
>> the GPL 2.0 license.
>>
>> Paul Hsieh's hash function, defined in trace-hash-local.h,
>> is still used in trace-graph.c, trace-plot.c, trace-plot-cpu.c
>> and trace-plot-task.c. Because trace-hash-local.h is no longer
>> included in trace-filter-hash.h, it has to be included
>> explicitly in these four source files.
>>
>> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
>> ---
> 
> I've applied these but haven't pushed them out yet. Which files need to
> be changed from GPL to LGPL? Now that we have removed the GPL code from
> the filter hash.
> 

I would like to have trace-filter-hash.h and trace-filter-hash.c changed 
to LGPL. Also I would like trace-filter-hash.o to became part of 
libtracecmd and respectively trace-filter-hash.h to be moved to 
/include/trace-cmd/

Thank you very much!

Yordan

> -- Steve
>